You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rajesh Battala <ra...@citrix.com> on 2013/08/19 08:26:27 UTC
Review Request 13641: Fix for build failure in 4.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13641/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh, edison su, and Sateesh Chodapuneedi.
Bugs: CLOUDSTACK-4391
Repository: cloudstack-git
Description
-------
4.2 build is failing as there is an issue with the Unittest for LibvirtComputingResourceTest with recent commit to LibvirtComputingResouce class.
Diffs
-----
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java 56d6536
Diff: https://reviews.apache.org/r/13641/diff/
Testing
-------
Created a possible fix for the issue
Applying the patch, KVM unittess are running successful.
KVM tests are passing successfully.
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running com.cloud.hypervisor.kvm.resource.LibvirtVifDriverTest
log4j:WARN No appenders could be found for logger (com.cloud.hypervisor.kvm.resource.LibvirtComputingResource).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.034 sec
Running com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.058 sec
Running com.cloud.hypervisor.kvm.resource.LibvirtVMDefTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.018 sec
Results :
Tests run: 13, Failures: 0, Errors: 0, Skipped: 0
Thanks
Rajesh Battala
Thanks,
Rajesh Battala
Re: Review Request 13641: Fix for build failure in 4.2
Posted by Rajesh Battala <ra...@citrix.com>.
> On Aug. 19, 2013, 1:01 p.m., Devdeep Singh wrote:
> > Committed to 4.2 in 6c593b0b16f37951c0c30b2ad3cff69835085fe2
Thanks for the review and pushing to repo
- Rajesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13641/#review25294
-----------------------------------------------------------
On Aug. 19, 2013, 6:26 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13641/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 6:26 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, edison su, and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-4391
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 4.2 build is failing as there is an issue with the Unittest for LibvirtComputingResourceTest with recent commit to LibvirtComputingResouce class.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java 56d6536
>
> Diff: https://reviews.apache.org/r/13641/diff/
>
>
> Testing
> -------
>
> Created a possible fix for the issue
> Applying the patch, KVM unittess are running successful.
>
> KVM tests are passing successfully.
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running com.cloud.hypervisor.kvm.resource.LibvirtVifDriverTest
> log4j:WARN No appenders could be found for logger (com.cloud.hypervisor.kvm.resource.LibvirtComputingResource).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.034 sec
> Running com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.058 sec
> Running com.cloud.hypervisor.kvm.resource.LibvirtVMDefTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.018 sec
>
> Results :
>
> Tests run: 13, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks
> Rajesh Battala
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 13641: Fix for build failure in 4.2
Posted by Devdeep Singh <de...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13641/#review25294
-----------------------------------------------------------
Ship it!
Committed to 4.2 in 6c593b0b16f37951c0c30b2ad3cff69835085fe2
- Devdeep Singh
On Aug. 19, 2013, 6:26 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13641/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 6:26 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, edison su, and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-4391
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 4.2 build is failing as there is an issue with the Unittest for LibvirtComputingResourceTest with recent commit to LibvirtComputingResouce class.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java 56d6536
>
> Diff: https://reviews.apache.org/r/13641/diff/
>
>
> Testing
> -------
>
> Created a possible fix for the issue
> Applying the patch, KVM unittess are running successful.
>
> KVM tests are passing successfully.
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running com.cloud.hypervisor.kvm.resource.LibvirtVifDriverTest
> log4j:WARN No appenders could be found for logger (com.cloud.hypervisor.kvm.resource.LibvirtComputingResource).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.034 sec
> Running com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.058 sec
> Running com.cloud.hypervisor.kvm.resource.LibvirtVMDefTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.018 sec
>
> Results :
>
> Tests run: 13, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks
> Rajesh Battala
>
>
> Thanks,
>
> Rajesh Battala
>
>
Re: Review Request 13641: Fix for build failure in 4.2
Posted by Ram Ganesh <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13641/#review25291
-----------------------------------------------------------
Ship it!
Ship It!
- Ram Ganesh
On Aug. 19, 2013, 6:26 a.m., Rajesh Battala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13641/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 6:26 a.m.)
>
>
> Review request for cloudstack, Devdeep Singh, edison su, and Sateesh Chodapuneedi.
>
>
> Bugs: CLOUDSTACK-4391
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 4.2 build is failing as there is an issue with the Unittest for LibvirtComputingResourceTest with recent commit to LibvirtComputingResouce class.
>
>
> Diffs
> -----
>
> plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java 56d6536
>
> Diff: https://reviews.apache.org/r/13641/diff/
>
>
> Testing
> -------
>
> Created a possible fix for the issue
> Applying the patch, KVM unittess are running successful.
>
> KVM tests are passing successfully.
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running com.cloud.hypervisor.kvm.resource.LibvirtVifDriverTest
> log4j:WARN No appenders could be found for logger (com.cloud.hypervisor.kvm.resource.LibvirtComputingResource).
> log4j:WARN Please initialize the log4j system properly.
> log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.034 sec
> Running com.cloud.hypervisor.kvm.resource.LibvirtComputingResourceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.058 sec
> Running com.cloud.hypervisor.kvm.resource.LibvirtVMDefTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.018 sec
>
> Results :
>
> Tests run: 13, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks
> Rajesh Battala
>
>
> Thanks,
>
> Rajesh Battala
>
>