You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pritisarap12 <gi...@git.apache.org> on 2015/11/04 10:22:38 UTC

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

GitHub user pritisarap12 opened a pull request:

    https://github.com/apache/cloudstack/pull/1031

    CLOUDSTACK-9026: Modifying testpath for adding missing parameter

    Addning service_offering creation in testpath_storage_migration.py testpath which is missing right now 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-9026-Modifying-testpath-for-adding-missing-parameter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1031
    
----
commit c2376334592835c30b865c2b08f8c179eed8d328
Author: Priti Sarap <pr...@clogeny.com>
Date:   2015-11-04T09:18:38Z

    CLOUDSTACK-9026: Modifying testpath for adding missing parameter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1031#discussion_r53309123
  
    --- Diff: test/integration/testpaths/testpath_storage_migration.py ---
    @@ -248,6 +248,11 @@ def setUpClass(cls):
                     DomainName=cls.account.domain
                 )
                 # Create Service offering
    +            cls.service_offering = ServiceOffering.create(
    +                cls.apiclient,
    +                cls.testdata["service_offering"]
    +            )
    +
    --- End diff --
    
    Added service_offering in cleanup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

Posted by pritisarap12 <gi...@git.apache.org>.
GitHub user pritisarap12 reopened a pull request:

    https://github.com/apache/cloudstack/pull/1031

    CLOUDSTACK-9026: Modifying testpath for adding missing parameter

    Adding service_offering creation in testpath_storage_migration.py testpath which is missing right now 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-9026-Modifying-testpath-for-adding-missing-parameter

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1031
    
----
commit c2376334592835c30b865c2b08f8c179eed8d328
Author: Priti Sarap <pr...@clogeny.com>
Date:   2015-11-04T09:18:38Z

    CLOUDSTACK-9026: Modifying testpath for adding missing parameter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 closed the pull request at:

    https://github.com/apache/cloudstack/pull/1031


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1031#discussion_r53300709
  
    --- Diff: test/integration/testpaths/testpath_storage_migration.py ---
    @@ -248,6 +248,11 @@ def setUpClass(cls):
                     DomainName=cls.account.domain
                 )
                 # Create Service offering
    +            cls.service_offering = ServiceOffering.create(
    +                cls.apiclient,
    +                cls.testdata["service_offering"]
    +            )
    +
    --- End diff --
    
    please add cls._cleanup.append(cls.service_offering)  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1031


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:

    https://github.com/apache/cloudstack/pull/1031#issuecomment-185662747
  
    LGTM  based on test results!!
    
    Test migrate Volume (root and data disk) ... === TestName: test_01_migrate_root_and_data_disk_nonlive | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 1 test in 1778.920s
    
    OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

Posted by shwetaag <gi...@git.apache.org>.
Github user shwetaag commented on the pull request:

    https://github.com/apache/cloudstack/pull/1031#issuecomment-186124001
  
    did cod walk thought. Looks good to me .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9026: Modifying testpath for a...

Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on the pull request:

    https://github.com/apache/cloudstack/pull/1031#issuecomment-185115938
  
    Testcase result:
    
    Test migrate Volume (root and data disk) ... === TestName: test_01_migrate_root_and_data_disk_nonlive | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 1 test in 1688.400s
    
    OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---