[jira] [Commented] (AMBARI-24394) Ambari Revision Control across Config Groups - show all changes across all Config Groups

["Akhil S Naik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-24394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565707#comment-16565707 ] 

Akhil S Naik commented on AMBARI-24394:
---------------------------------------

Hi [~harisekhon] ,

I am a contributor to Ambari Web project.
I happened to see this issue.

I see currently Apache Ambari is on version 2.7.0 where UI is so different and the issue you are referring to is usability point of view.

Configs groups are not shown for the 'default' configuration becuase none of them was applied to default.
though i will discuss with other ambari engineers to see if those configs that is made to config groups should be in the slider if the selected version is default

Meanwhile, if you would like to see all config groups each time it can be easily tweaked in javascript.

Steps

1) navigate to /usr/lib/ambari-server/web/javascripts
2) take backup of app.js
cp app.js /tmp/app.js_backup
3) vi app.js

find this function in editor 'serviceVersions: function () {'

In this function there will be a varaible defined : 'var serviceVersions'

by default its value will be : 

{code:java}
var serviceVersions = this.get('allServiceVersions').filter(function(s) {
      return s.get('groupId') === groupId || s.get('groupName') === App.ServiceConfigGroup.defaultGroupName;
     });
{code}


change it to : 


{code:java}
var serviceVersions = this.get('allServiceVersions');
{code}


inshort if you do a diff it will look like thi s: 


{code:java}
[root@host5 javascripts]# diff app.js app.js.backu
194607c194607,194609
<     var serviceVersions = this.get('allServiceVersions');
---
>     var serviceVersions = this.get('allServiceVersions').filter(function(s) {
>       return s.get('groupId') === groupId || s.get('groupName') === App.ServiceConfigGroup.defaultGroupName;
>     });
{code}


Then reload the browser with key with cntrl+F5 ( hard reload) . you will have all config versions loaded to the UI as you requested.
Please revert if this doesnt helped.





> Ambari Revision Control across Config Groups - show all changes across all Config Groups
> ----------------------------------------------------------------------------------------
>
>                 Key: AMBARI-24394
>                 URL: https://issues.apache.org/jira/browse/AMBARI-24394
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-server
>    Affects Versions: 2.5.2
>            Reporter: Hari Sekhon
>            Assignee: Akhil S Naik
>            Priority: Major
>
> When using config groups and making changes to a config group, then selecting default, it doesn't show any configuration change because none was applied to default.
> This is not good because when reviewing the configs it looks like no change was made recently, only when selecting the other config group drop down does a newer revision change become visible in the version slider near the top of the config page.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)