You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/12/29 02:37:12 UTC

[PR] Component initialization order adjustment, add resource constraints. (eventmesh)

Alonexc opened a new pull request, #4693:
URL: https://github.com/apache/eventmesh/pull/4693

   …ponent initialization order rules and DNS.
   
   <!--
   ### Contribution Checklist
   
     - Name the pull request in the form "[ISSUE #XXXX] Title of the pull request", 
       where *XXXX* should be replaced by the actual issue number.
       Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
   
     - Fill out the template below to describe the changes contributed by the pull request. 
       That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue. 
       Please do not mix up code from multiple issues.
     
     - Each commit in the pull request should have a meaningful commit message.
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, 
       leaving only the filled out template below.
   
   (The sections below can be removed for hotfixes of typos)
   -->
   
   <!--
   (If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
   -->
   
   Fixes #<XXXX>.
   
   ### Motivation
   
   Component initialization order adjustment, add resource constraints.
   
   ### Modifications
   
   Component initialization order adjustment, add resource constraints.
   
   ### Documentation
   
   - Does this pull request introduce a new feature? no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


Re: [PR] [ISSUE #4694] Component initialization order adjustment, add resource constraints. (eventmesh)

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693#discussion_r1447147809


##########
eventmesh-operator/config/samples/eventmesh_v1_connectors_rocketmq.yaml:
##########
@@ -86,11 +86,11 @@ spec:
       # resources describes the compute resource requirements and limits
       resources:
         requests:
-          memory: "512Mi"
-          cpu: "250m"
+          memory: 512Mi
+          cpu: 250m
         limits:
-          memory: "1024Mi"
-          cpu: "500m"
+          memory: 1024Mi
+          cpu: 500m

Review Comment:
   <img width="561" alt="image" src="https://github.com/apache/eventmesh/assets/91315508/acff8316-6bba-41d7-93c5-1cd3ffce2e9f">   
   
   There may be some deviation. I have revised it according to your opinion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4694] Component initialization order adjustment, add resource constraints. (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693#discussion_r1446891659


##########
eventmesh-operator/config/samples/eventmesh_v1_runtime.yaml:
##########
@@ -271,6 +284,14 @@ spec:
               name: runtime-config
           # imagePullPolicy is the image pull policy
           imagePullPolicy: Always
+          # resources describes the compute resource requirements and limits
+          resources:
+            requests:
+              memory: "1024Mi"
+              cpu: "250m"
+            limits:
+              memory: "2048Mi"
+              cpu: "500m"

Review Comment:
   Are these resources set for EventMesh Runtime?
   
   The memory limit set for EventMesh Runtime in start.sh is 8G. Although it typically requires less, the limit of 2G is too strict.
   
   The threadPools in EventMesh Runtime are designed for 4~8 core machines to speed up async processor.
   
   We can use eventmesh image under apache namespace in future updates.
   
   Besides, why are the values of the properties enclosed in double quotation marks here, while they are not in https://github.com/apache/eventmesh/pull/4727?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4694] Component initialization order adjustment, add resource constraints. (eventmesh)

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693#issuecomment-1884112980

   > May I ask that is this PR working in progress or ready for review?
   
   This pr is ready for review and has been tested with pr #4727. The image used at this stage is built on this basis.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4694] Component initialization order adjustment, add resource constraints. (eventmesh)

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693#discussion_r1446934933


##########
eventmesh-operator/config/samples/eventmesh_v1_runtime.yaml:
##########
@@ -271,6 +284,14 @@ spec:
               name: runtime-config
           # imagePullPolicy is the image pull policy
           imagePullPolicy: Always
+          # resources describes the compute resource requirements and limits
+          resources:
+            requests:
+              memory: "1024Mi"
+              cpu: "250m"
+            limits:
+              memory: "2048Mi"
+              cpu: "500m"

Review Comment:
   > Are these resources set for EventMesh Runtime?
   > 
   > The memory limit set for EventMesh Runtime in start.sh is 8G. Although it typically requires less, the limit of 2G is too strict.
   > 
   > The threadPools in EventMesh Runtime are designed for 4~8 core machines to speed up async processor.
   > 
   > We can use eventmesh image under apache namespace in future updates.
   > 
   > Besides, why are the values of the properties enclosed in double quotation marks here, while they are not in #4727? 
   
   1.This side I use their own computer to do the test, due to limited resources, so set some low, easy to do the test, in your opinion, you think runtime, connector, how much more appropriate ? 
   2.For this double quote, this is only a format of yaml, this part is a common string, so it can be added or not, the difference is that if there are special symbols in the string, you need to add double quotes. If you need to unify, you can remove this double quotation mark.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4694] Component initialization order adjustment, add resource constraints. (eventmesh)

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693#discussion_r1446934933


##########
eventmesh-operator/config/samples/eventmesh_v1_runtime.yaml:
##########
@@ -271,6 +284,14 @@ spec:
               name: runtime-config
           # imagePullPolicy is the image pull policy
           imagePullPolicy: Always
+          # resources describes the compute resource requirements and limits
+          resources:
+            requests:
+              memory: "1024Mi"
+              cpu: "250m"
+            limits:
+              memory: "2048Mi"
+              cpu: "500m"

Review Comment:
   > Are these resources set for EventMesh Runtime?
   > 
   > The memory limit set for EventMesh Runtime in start.sh is 8G. Although it typically requires less, the limit of 2G is too strict.
   > 
   > The threadPools in EventMesh Runtime are designed for 4~8 core machines to speed up async processor.
   > 
   > We can use eventmesh image under apache namespace in future updates.
   > 
   > Besides, why are the values of the properties enclosed in double quotation marks here, while they are not in #4727? 
   
   @Pil0tXia 1.This side I use their own computer to do the test, due to limited resources, so set some low, easy to do the test, in your opinion, you think runtime, connector, how much more appropriate ? 
   2.For this double quote, this is only a format of yaml, this part is a common string, so it can be added or not, the difference is that if there are special symbols in the string, you need to add double quotes. If you need to unify, you can remove this double quotation mark.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4694] Component initialization order adjustment, add resource constraints. (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693#discussion_r1446963752


##########
eventmesh-operator/config/samples/eventmesh_v1_runtime.yaml:
##########
@@ -271,6 +284,14 @@ spec:
               name: runtime-config
           # imagePullPolicy is the image pull policy
           imagePullPolicy: Always
+          # resources describes the compute resource requirements and limits
+          resources:
+            requests:
+              memory: "1024Mi"
+              cpu: "250m"
+            limits:
+              memory: "2048Mi"
+              cpu: "500m"

Review Comment:
   For a standard deployment senario, this will be enough:
   
   ```suggestion
             resources:
               requests:
                 memory: 2048Mi
                 cpu: 4000m
               limits:
                 memory: 8192Mi
                 cpu: 8000m
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4694] Component initialization order adjustment, add resource constraints. (eventmesh)

Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


Re: [PR] [ISSUE #4694] Component initialization order adjustment, add resource constraints. (eventmesh)

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693#discussion_r1446934933


##########
eventmesh-operator/config/samples/eventmesh_v1_runtime.yaml:
##########
@@ -271,6 +284,14 @@ spec:
               name: runtime-config
           # imagePullPolicy is the image pull policy
           imagePullPolicy: Always
+          # resources describes the compute resource requirements and limits
+          resources:
+            requests:
+              memory: "1024Mi"
+              cpu: "250m"
+            limits:
+              memory: "2048Mi"
+              cpu: "500m"

Review Comment:
   > Are these resources set for EventMesh Runtime?
   > 
   > The memory limit set for EventMesh Runtime in start.sh is 8G. Although it typically requires less, the limit of 2G is too strict.
   > 
   > The threadPools in EventMesh Runtime are designed for 4~8 core machines to speed up async processor.
   > 
   > We can use eventmesh image under apache namespace in future updates.
   > 
   > Besides, why are the values of the properties enclosed in double quotation marks here, while they are not in #4727? 
   
   @Pil0tXia  
   1.This side I use their own computer to do the test, due to limited resources, so set some low, easy to do the test, in your opinion, you think runtime, connector, how much more appropriate ? 
   2.For this double quote, this is only a format of yaml, this part is a common string, so it can be added or not, the difference is that if there are special symbols in the string, you need to add double quotes. If you need to unify, you can remove this double quotation mark.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4694] Component initialization order adjustment, add resource constraints. (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693#issuecomment-1883289077

   May I ask that is this PR working in progress or ready for review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] Component initialization order adjustment, add resource constraints. (eventmesh)

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693#issuecomment-1871700317

   ## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4693?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base [(`87ed40d`)](https://app.codecov.io/gh/apache/eventmesh/commit/87ed40d99916cef2e00a8f9ecff4c315b62fdfdd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 17.38% compared to head [(`ab998ae`)](https://app.codecov.io/gh/apache/eventmesh/pull/4693?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 17.38%.
   > Report is 19 commits behind head on master.
   
   > :exclamation: Current head ab998ae differs from pull request most recent head 88047a8. Consider uploading reports for the commit 88047a8 to get more accurate results
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4693      +/-   ##
   ============================================
   - Coverage     17.38%   17.38%   -0.01%     
   - Complexity     1757     1759       +2     
   ============================================
     Files           797      797              
     Lines         29776    29845      +69     
     Branches       2573     2577       +4     
   ============================================
   + Hits           5177     5188      +11     
   - Misses        24121    24174      +53     
   - Partials        478      483       +5     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/4693?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4694] Component initialization order adjustment, add resource constraints. (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693#discussion_r1447119867


##########
eventmesh-operator/config/samples/eventmesh_v1_connectors_rocketmq.yaml:
##########
@@ -86,11 +86,11 @@ spec:
       # resources describes the compute resource requirements and limits
       resources:
         requests:
-          memory: "512Mi"
-          cpu: "250m"
+          memory: 512Mi
+          cpu: 250m
         limits:
-          memory: "1024Mi"
-          cpu: "500m"
+          memory: 1024Mi
+          cpu: 500m

Review Comment:
   The RocketMQ connector is a single-threaded application, which means it has limited consumption speed. It operates in scenarios where network I/O is dominant. In theory, it would require a maximum of 1 CPU when there is a sudden surge of messages from the upstream. I'm not sure if 0.5 CPU is sufficient. Could you please set the limit to 1 CPU or higher and use the "kubectl top pod" command to check the maximum CPU usage when the connector consumes messages?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4694] Component initialization order adjustment, add resource constraints. (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693#discussion_r1446963752


##########
eventmesh-operator/config/samples/eventmesh_v1_runtime.yaml:
##########
@@ -271,6 +284,14 @@ spec:
               name: runtime-config
           # imagePullPolicy is the image pull policy
           imagePullPolicy: Always
+          # resources describes the compute resource requirements and limits
+          resources:
+            requests:
+              memory: "1024Mi"
+              cpu: "250m"
+            limits:
+              memory: "2048Mi"
+              cpu: "500m"

Review Comment:
   For a standard deployment senario, this will be enough:
   
   ```suggestion
             resources:
               requests:
                 memory: 2048Mi
                 cpu: 2000m
               limits:
                 memory: 8192Mi
                 cpu: 8000m
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org


Re: [PR] [ISSUE #4694] Component initialization order adjustment, add resource constraints. (eventmesh)

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693#discussion_r1447055179


##########
eventmesh-operator/config/samples/eventmesh_v1_runtime.yaml:
##########
@@ -271,6 +284,14 @@ spec:
               name: runtime-config
           # imagePullPolicy is the image pull policy
           imagePullPolicy: Always
+          # resources describes the compute resource requirements and limits
+          resources:
+            requests:
+              memory: "1024Mi"
+              cpu: "250m"
+            limits:
+              memory: "2048Mi"
+              cpu: "500m"

Review Comment:
   @Pil0tXia Modifications have been made.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org