You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Mete Atamel (JIRA)" <ji...@apache.org> on 2012/09/28 14:57:07 UTC

[jira] [Comment Edited] (OAK-349) [MongoMK] CommitImpl constructor with instructions list should be removed

    [ https://issues.apache.org/jira/browse/OAK-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465583#comment-13465583 ] 

Mete Atamel edited comment on OAK-349 at 9/28/12 11:55 PM:
-----------------------------------------------------------

Latest patch fixes a few JSOP parser bugs. Can someone apply this patch for me as it's a big change?
                
      was (Author: meteatamel):
    Latest patch fixes a few JSOP parser bugs.
                  
> [MongoMK] CommitImpl constructor with instructions list should be removed
> -------------------------------------------------------------------------
>
>                 Key: OAK-349
>                 URL: https://issues.apache.org/jira/browse/OAK-349
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: mk
>    Affects Versions: 0.6
>            Reporter: Mete Atamel
>            Priority: Minor
>         Attachments: OAK-349.patch
>
>
> Realized that most tests use CommitImpl's constructor with instructions list and pass in an instructions list manually. This is not good because it by-passes JSOP parsing. Instead, tests should use CommitBuilder#build method so JSOP parsing is invoked.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira