You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Rainy-Memory (via GitHub)" <gi...@apache.org> on 2023/02/28 08:55:26 UTC

[GitHub] [tvm] Rainy-Memory opened a new pull request, #14143: [Fix][MetaSchedule] Fix redundant stages in async pipeline for mlt

Rainy-Memory opened a new pull request, #14143:
URL: https://github.com/apache/tvm/pull/14143

   This PR fixes redundant stages if visiting `InitializeWithTuneContext` multiple times.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14143: [Fix][MetaSchedule] Fix redundant stages in async pipeline for mlt

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14143:
URL: https://github.com/apache/tvm/pull/14143#issuecomment-1447800462

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @ibsidorenko <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao merged pull request #14143: [Fix][MetaSchedule] Fix redundant stages in async pipeline for mlt

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao merged PR #14143:
URL: https://github.com/apache/tvm/pull/14143


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao commented on pull request #14143: [Fix][MetaSchedule] Fix redundant stages in async pipeline for mlt

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #14143:
URL: https://github.com/apache/tvm/pull/14143#issuecomment-1447801835

   please add a unittest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao commented on a diff in pull request #14143: [Fix][MetaSchedule] Fix redundant stages in async pipeline for mlt

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on code in PR #14143:
URL: https://github.com/apache/tvm/pull/14143#discussion_r1119747707


##########
src/meta_schedule/schedule_rule/multi_level_tiling.cc:
##########
@@ -96,7 +96,9 @@ void MultiLevelTilingNode::InitializeWithTuneContext(const TuneContext& context)
         if (std::stoi(sm) >= 80) {
           // only stage = 4 & 5 is tested. all integer that is bigger than 2
           // is theoretically feasible, but no guarantee for great performance.
-          this->stages.insert(this->stages.end(), {4, 5});
+          this->stages = {4, 5};
+        } else {
+          this->stages.clear();

Review Comment:
   let's set the default value of `this->stages` to empty vector



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org