You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/07/25 10:15:38 UTC
[GitHub] flink pull request #4394: [FLINK-7257] [runtime] Enable checkstyle for test ...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4394
[FLINK-7257] [runtime] Enable checkstyle for test files in flink-runtime
With this PR checkstyle rules are also applied to test sources in flink-runtime.
No packages for which we enabled checkstyle already was affected. For the remaining packages i either added an exclusion specifically for tests (same pattern introduced in #4384), or fixed the violations if there were only 1 or 2 anyway.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7257
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4394.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4394
----
commit 832920acf2356aa4b05dd2455eb48c8986ae0628
Author: zentol <ch...@apache.org>
Date: 2017-07-24T14:28:51Z
[FLINK-7257] [runtime] Enable checkstyle for test files in flink-runtime
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4394: [FLINK-7257] [runtime] Enable checkstyle for test ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4394
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4394: [FLINK-7257] [runtime] Enable checkstyle for test files i...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4394
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4394: [FLINK-7257] [runtime] Enable checkstyle for test files i...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/4394
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4394: [FLINK-7257] [runtime] Enable checkstyle for test files i...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4394
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---