You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/02/08 23:28:23 UTC
Review Request 43341: Fixing eclipse project generation for extensions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43341/
-----------------------------------------------------------
Review request for geode, Anthony Baker, Jens Deppe, and Kirk Lund.
Repository: geode
Description
-------
Eclipse was not happy with project names with / in them. Fixing the
names of the eclipse projects that are generated.
Diffs
-----
gradle/ide.gradle e4c7df5331eedf72111ebb13b6e9e03d2052c1b3
Diff: https://reviews.apache.org/r/43341/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 43341: Fixing eclipse project generation for
extensions
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43341/#review118310
-----------------------------------------------------------
Should this change be combined with this bit of logic? https://github.com/apache/incubator-geode/blob/develop/gradle/java.gradle#L129
- Jens Deppe
On Feb. 8, 2016, 10:28 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43341/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 10:28 p.m.)
>
>
> Review request for geode, Anthony Baker, Jens Deppe, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Eclipse was not happy with project names with / in them. Fixing the
> names of the eclipse projects that are generated.
>
>
> Diffs
> -----
>
> gradle/ide.gradle e4c7df5331eedf72111ebb13b6e9e03d2052c1b3
>
> Diff: https://reviews.apache.org/r/43341/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 43341: Fixing eclipse project generation for
extensions
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43341/#review118347
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On Feb. 9, 2016, 12:34 a.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43341/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 12:34 a.m.)
>
>
> Review request for geode, Anthony Baker, Jens Deppe, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Eclipse was not happy with project names with / in them. Fixing the
> names of the eclipse projects that are generated.
>
>
> Diffs
> -----
>
> build.gradle 059cf312d2d44a3a2f1e2d2c0491b48aedd9c813
> gradle/ide.gradle e4c7df5331eedf72111ebb13b6e9e03d2052c1b3
> gradle/java.gradle 015da2f161e839d063de6f28bca2ea9e8ff98fc7
> gradle/utilities.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/43341/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 43341: Fixing eclipse project generation for
extensions
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43341/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 12:34 a.m.)
Review request for geode, Anthony Baker, Jens Deppe, and Kirk Lund.
Changes
-------
Applying feeback from Jens - consolodating the logic to strip off the extensions part of the project name into a utilities.gradle file.
Repository: geode
Description
-------
Eclipse was not happy with project names with / in them. Fixing the
names of the eclipse projects that are generated.
Diffs (updated)
-----
build.gradle 059cf312d2d44a3a2f1e2d2c0491b48aedd9c813
gradle/ide.gradle e4c7df5331eedf72111ebb13b6e9e03d2052c1b3
gradle/java.gradle 015da2f161e839d063de6f28bca2ea9e8ff98fc7
gradle/utilities.gradle PRE-CREATION
Diff: https://reviews.apache.org/r/43341/diff/
Testing
-------
Thanks,
Dan Smith