You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jake Farrell <jf...@apache.org> on 2014/04/29 04:43:12 UTC
Review Request 20824: AURORA-278: Review Incubator release check list -
missing license headers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20824/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-278
https://issues.apache.org/jira/browse/AURORA-278
Repository: aurora
Description
-------
AURORA-278: Review Incubator release check list
Adds missing license headers in python files.
Diffs
-----
src/main/python/apache/aurora/common/shellify.py 67d81f0983a343d5527ce6152bad2d591e5f08dd
src/test/python/apache/aurora/common/test_shellify.py 8ecce7ff98769cd17cc016bee30750c5841fa942
Diff: https://reviews.apache.org/r/20824/diff/
Testing
-------
Since there is no checkstyle yet for py code ran following check to see which py files where missing headers still
Dir['src/**/*.py'].each { |f| content = File.open(f).read(); next if content.empty? ; puts f unless File.open(f).read().include?("Apache Software Foundation") }
Thanks,
Jake Farrell
Re: Review Request 20824: AURORA-278: Review Incubator release check list -
missing license headers
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20824/#review41774
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On April 29, 2014, 1:51 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20824/
> -----------------------------------------------------------
>
> (Updated April 29, 2014, 1:51 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Bugs: AURORA-278
> https://issues.apache.org/jira/browse/AURORA-278
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-278: Review Incubator release check list
>
> Adds missing license headers in python files.
>
>
> Diffs
> -----
>
> LICENSE 1aea1f72b3a17da4804e8e1918311f07a14f1b0a
> examples/vagrant/test_tutorial.sh b607c3a8306cd6d62b6f6508ee336b5bb3cddd88
> src/main/python/apache/aurora/common/shellify.py 67d81f0983a343d5527ce6152bad2d591e5f08dd
> src/main/python/apache/thermos/observer/http/assets/jquery.pailer.js 5962f9e9d347f10610229e9a50d1e2a93f2f8dc0
> src/main/python/apache/thermos/observer/http/assets/observer.js 84aec5d8d762a9b51d0620dcc7a7a602dd2676c9
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 8806964c2c60f0777b38ae42375a0ca89e5a5a7e
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js e0b3aab6b383f59094785e50ecfc839695e4a038
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 5d6f2b6665915c84c76e2b930e498c8972ae5094
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 2a3959c6308bebff87c297191d36612d0510d546
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js e04c8c61ecef920cafe879d6d12b337783c70f10
> src/test/python/apache/aurora/common/test_shellify.py 8ecce7ff98769cd17cc016bee30750c5841fa942
>
> Diff: https://reviews.apache.org/r/20824/diff/
>
>
> Testing
> -------
>
> Since there is no checkstyle yet for py code ran following check to see which py files where missing headers still
>
> Dir['src/**/*.py'].each { |f| content = File.open(f).read(); next if content.empty? ; puts f unless File.open(f).read().include?("Apache Software Foundation") }
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 20824: AURORA-278: Review Incubator release check list -
missing license headers
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20824/
-----------------------------------------------------------
(Updated April 29, 2014, 8:51 p.m.)
Review request for Aurora and Kevin Sweeney.
Changes
-------
Updating js, py and sh files with missing license headers, updates LICENSE as well for multiple jQuery paths
Bugs: AURORA-278
https://issues.apache.org/jira/browse/AURORA-278
Repository: aurora
Description
-------
AURORA-278: Review Incubator release check list
Adds missing license headers in python files.
Diffs (updated)
-----
LICENSE 1aea1f72b3a17da4804e8e1918311f07a14f1b0a
examples/vagrant/test_tutorial.sh b607c3a8306cd6d62b6f6508ee336b5bb3cddd88
src/main/python/apache/aurora/common/shellify.py 67d81f0983a343d5527ce6152bad2d591e5f08dd
src/main/python/apache/thermos/observer/http/assets/jquery.pailer.js 5962f9e9d347f10610229e9a50d1e2a93f2f8dc0
src/main/python/apache/thermos/observer/http/assets/observer.js 84aec5d8d762a9b51d0620dcc7a7a602dd2676c9
src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js 8806964c2c60f0777b38ae42375a0ca89e5a5a7e
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js e0b3aab6b383f59094785e50ecfc839695e4a038
src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 5d6f2b6665915c84c76e2b930e498c8972ae5094
src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 2a3959c6308bebff87c297191d36612d0510d546
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js e04c8c61ecef920cafe879d6d12b337783c70f10
src/test/python/apache/aurora/common/test_shellify.py 8ecce7ff98769cd17cc016bee30750c5841fa942
Diff: https://reviews.apache.org/r/20824/diff/
Testing
-------
Since there is no checkstyle yet for py code ran following check to see which py files where missing headers still
Dir['src/**/*.py'].each { |f| content = File.open(f).read(); next if content.empty? ; puts f unless File.open(f).read().include?("Apache Software Foundation") }
Thanks,
Jake Farrell