[GitHub] [lucene] dsmiley commented on a change in pull request #180: LUCENE-9959: Add non thread local based API for term vector reader usage

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #180:
URL: https://github.com/apache/lucene/pull/180#discussion_r655067190



##########
File path: lucene/core/src/java/org/apache/lucene/index/TermVectors.java
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.index;
+
+import java.io.IOException;
+import org.apache.lucene.analysis.tokenattributes.OffsetAttribute;
+
+/** Index API to access TermVectors */
+public abstract class TermVectors {

Review comment:
       I agree with Rob's point of view.  In my mind it's a matter of taste.  Given that Java only lets you have one inheritor, I think of that particular inheritor as forming an important part of an identify of new class choosing to subclass it.  It's like implicit documentation to consider what a class subclasses as being more important than the interfaces it implements.  If someone is going to write a TermVectors impl, then surely that's an important part of its identity.  Perhaps it might implement Closeable or other interfaces but those won't be as important to understanding what this class is/does, not as much as it being a TermVectors subclass.  Interfaces are good for generic abstractions.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org