You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rodent of Unusual Size <co...@decus.org> on 1997/05/29 13:16:18 UTC
[PATCH] rollback of unwarranted change (was: [PATCH] unwarranted
change to rfc1413.c)
Let me rename the message so it's a little more clear that this
patch is rolling back an unwarranted change, not supplying one. :->
A retroactive -1 on the patch, and on a 1.2 tarball, until this is
corrected - then +1. :-)
#ken :-/}
>From the fingers of Rodent of Unusual Size flowed the following:
>
> Unfortunately, the recent setjmp fix to rfc1413.c changed something
> completely unrelated, and upon which one of my modules depends:
> namely, the declaration of rfc1413_timeout as a global int. This
> needs to be put back, please.
>
> Sorry I couldn't respond in a more timely fashion, but my systems
> just came back online yesterday afternoon and I wasn't able to test
> the patch before it was committed.
>
> #ken :-(}
>
>Index: rfc1413.c
>===================================================================
>RCS file: /export/home/cvs/apache/src/rfc1413.c,v
>retrieving revision 1.10
>diff -c -r1.10 rfc1413.c
>*** rfc1413.c 1997/05/29 04:50:27 1.10
>--- rfc1413.c 1997/05/29 11:00:10
>***************
>*** 95,100 ****
>--- 95,102 ----
> #define ANY_PORT 0 /* Any old port will do */
> #define FROM_UNKNOWN "unknown"
>
>+ int rfc1413_timeout = RFC1413_TIMEOUT; /* Global so it can be changed */
>+
> JMP_BUF timebuf;
>
> /* bind_connect - bind both ends of a socket */
>***************
>*** 208,214 ****
> if (ap_setjmp(timebuf) == 0)
> {
> signal(SIGALRM, ident_timeout);
>! alarm(RFC1413_TIMEOUT);
>
> if (get_rfc1413(sock, &conn->local_addr, &conn->remote_addr, user,
> srv)
>--- 210,216 ----
> if (ap_setjmp(timebuf) == 0)
> {
> signal(SIGALRM, ident_timeout);
>! alarm(rfc1413_timeout);
>
> if (get_rfc1413(sock, &conn->local_addr, &conn->remote_addr, user,
> srv)