You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/10 00:42:28 UTC

[GitHub] [spark] huaxingao commented on pull request #29837: [SPARK-32463][SQL][DOCS] Add "Type Conversion" section in "Supported Data Types" of SQL docs

huaxingao commented on pull request #29837:
URL: https://github.com/apache/spark/pull/29837#issuecomment-706456541


   This looks good to me overall. Thank for the good work! @planga82 
   A couple of comments: 
   1. Could you please put a `;` in the end of the SQL statements in the examples?
   2. I quickly tried a few explicit casting, seems I can cast Boolean to Timestamp OK? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org