You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/16 16:14:56 UTC
[GitHub] [kafka] clolov opened a new pull request, #12301: KAFKA-14003: Migrate streams module to JUnit 5 - Part 2
clolov opened a new pull request, #12301:
URL: https://github.com/apache/kafka/pull/12301
This pull request addresses https://issues.apache.org/jira/browse/KAFKA-14003. It is the second of a series of pull requests which address the move of Kafka Streams tests from JUnit 4 to JUnit 5.
**This pull request will be rebased on top of https://github.com/apache/kafka/pull/12285 once it is merged. The file streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java is only added in this pull request for the build to succeed.**
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12301: KAFKA-14003: Migrate streams module to JUnit 5 - Part 2
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12301:
URL: https://github.com/apache/kafka/pull/12301#issuecomment-1357691852
@clolov @ijuma once the conflicts are resolved, we can merge this PR since all those tests do not contain EasyMock/PowerMock mocks which we agreed to migrate to Mockito before we migrate to JUnit 5.
@clolov could you please resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #12301: KAFKA-14003: Migrate streams module to JUnit 5 - Part 2
Posted by GitBox <gi...@apache.org>.
cadonna commented on PR #12301:
URL: https://github.com/apache/kafka/pull/12301#issuecomment-1378391578
Failures are unrelated:
```
Build / JDK 17 and Scala 2.13 / kafka.api.TransactionsTest.testBumpTransactionalEpoch(String).quorum=kraft
Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testTrustStoreAlter(String).quorum=kraft
Build / JDK 11 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testTrustStoreAlter(String).quorum=kraft
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on pull request #12301: KAFKA-14003: Migrate streams module to JUnit 5 - Part 2
Posted by GitBox <gi...@apache.org>.
clolov commented on PR #12301:
URL: https://github.com/apache/kafka/pull/12301#issuecomment-1369472092
Hello @cadonna, I have rebased the pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on a diff in pull request #12301: KAFKA-14003: Migrate streams module to JUnit 5 - Part 2
Posted by GitBox <gi...@apache.org>.
clolov commented on code in PR #12301:
URL: https://github.com/apache/kafka/pull/12301#discussion_r899274256
##########
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##########
@@ -236,6 +238,16 @@ public static String safeUniqueTestName(final Class<?> testClass, final TestName
.replace('=', '_');
}
+ public static String safeUniqueTestName(final Class<?> testClass, final TestInfo testInfo) {
Review Comment:
The file streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java is only added in this pull request for the build to succeed. It will be removed once https://github.com/apache/kafka/pull/12285 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #12301: KAFKA-14003: Migrate streams module to JUnit 5 - Part 2
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12301:
URL: https://github.com/apache/kafka/pull/12301#issuecomment-1356058365
@cadonna Can we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on pull request #12301: KAFKA-14003: Migrate streams module to JUnit 5 - Part 2
Posted by GitBox <gi...@apache.org>.
clolov commented on PR #12301:
URL: https://github.com/apache/kafka/pull/12301#issuecomment-1180174990
Politely bumping for a review @cadonna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #12301: KAFKA-14003: Migrate streams module to JUnit 5 - Part 2
Posted by GitBox <gi...@apache.org>.
cadonna merged PR #12301:
URL: https://github.com/apache/kafka/pull/12301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org