You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Marc Carter <dr...@gmail.com> on 2019/03/05 10:42:38 UTC
IntelliJ IDEA setup for Apache Camel
Official instructions for IntelliJ(*) point to files that no longer
exist. I'm sure there's some history to this but it does mean I (and
anyone else not using Eclipse) is missing the checkstyle and format
rules that prevent poor quality checkins.
I have learnt the command-line version but it's no substitute for your
IDE getting the details correct as you type!
./mvnw -TC1 -pl :camel-module1,:camel-module2 -Pfastinstall -Psourcecheck
Are there any newer IJ instructions or should I set this up myself?
Marc
(*) http://camel.apache.org/set-up-your-ide.html
Re: IntelliJ IDEA setup for Apache Camel
Posted by Zoran Regvart <zo...@regvart.com>.
Hi Cameleers,
I've changed the headers (from `/**` to `/*`), make sure that you have
a freshly built buildingtools module installed in your local Maven
repository so all the configuration (license, checkstyle) lines up.
Thanks Marc for bringing attention to this and pushing it through :)
zoran
On Mon, Mar 18, 2019 at 4:23 PM Zoran Regvart <zo...@regvart.com> wrote:
>
> Hi Marc,
> I can do that not an issue :) I'll open an issue[1] first and let
> anyone else to chime in if they wish.
>
> zoran
>
> [1] https://issues.apache.org/jira/browse/CAMEL-13336
>
> On Mon, Mar 18, 2019 at 2:19 PM Marc Carter <dr...@gmail.com> wrote:
> >
> > Ok. Not sure if I should take that on via non-committer public PR of
> > 18000 Java files?
> >
> > On 3/18/19 12:29 PM, Zoran Regvart wrote:
> > > Hi Marc,
> > > I would not mind to touch every Java file to fix the headers, that
> > > should also be easily automated via `mvn license:format` after
> > > changing the `header-java.txt`[1], we should also make sure that
> > > Checkstyle and RAT configuration matches.
> > >
> > > zoran
> > >
> > > [1] https://github.com/apache/camel/blob/master/buildingtools/src/main/resources/header-java.txt
> > >
> > > On Mon, Mar 18, 2019 at 12:01 PM Marc Carter <dr...@gmail.com> wrote:
> > >> Interesting one perhaps Apache knows about at a general level...
> > >> Per comments on IntelliJ issue I raised:
> > >> https://youtrack.jetbrains.com/issue/IDEA-208439 Java formatting amends OSS license headers as JavaDoc
> > >>
> > >> Camel (* and apparently many others) is mistakenly applying the *.java license header as a /** */ dangling Javadoc instead of a /* */ multi-line comment. Eclipse has a "workaround" in its formatter to skip header-comments. Options:
> > >> (a) make no change
> > >> I will add explicit IntellIJ formatter rules to ignore all "dangling javadocs" (overly broad but not too evil provided CheckStyle backs us up by enabling the same as a read-only verification)
> > >> (b) change the header file and let Java files change "organically"
> > >> Probably a terrible idea...
> > >> (c) touch every source file
> > >> I wouldn't have bothered raising this normally but, right now, (c) is not dissimilar to the major directory restructuring occurring in 3.0.0
> > >>
> > >> Marc
> > >>
> > >> (*) FYI
> > >> https://issues.apache.org/jira/browse/HIVE-17952 Fix license headers to avoid dangling javadoc warnings
> > >> https://github.com/palantir/atlasdb/issues/1693Copyright text in code should be in comment and not JavaDoc
> > >> https://github.com/mycila/license-maven-plugin/issues/118 license
> > >> headers for java files https://github.com/yegor256/eo/issues/109 Qulice
> > >> incorrectly requires that the license text is in a Javadoc comment
> > >>
> > >> On 3/6/19 9:24 AM, Zoran Regvart wrote:
> > >>> Hi Marc,
> > >>> yes, the files in `buildingtools/src/main/resources` are used when we
> > >>> run Checkstyle as a part of our build on Jenkins and during the
> > >>> release.
> > >>>
> > >>> You can also cleanup the duplicate files, not sure why those remained there.
> > >>>
> > >>> Thanks :)
> > >>>
> > >>> zoran
> > >>>
> > >>> On Wed, Mar 6, 2019 at 10:22 AM Marc Carter <dr...@gmail.com> wrote:
> > >>>> So I'm hearing that `buildingtools/src/main/resources` is canonical
> > >>>> (including all dupe files in `buildingtools`). They have slightly
> > >>>> different content and even different change histories - probably because
> > >>>> of this confusion. I'm not going to check the fine detail of all of
> > >>>> these though. If unofficial ones are not part of the builds, they should
> > >>>> be deleted?
> > >>>>
> > >>>> I'm going to PR the result of these conversations along with IJ setup
> > >>>> when ready
> > >>>>
> > >>>> Marc
> > >>>>
> > >>>> PS. Raised an issue on IJ code formatting as we cannot yet just "import
> > >>>> the Eclipse format" because of a limitation
> > >>>>
> > >>>> https://youtrack.jetbrains.com/issue/IDEA-208439 Java formatting amends
> > >>>> OSS license headers
> > >>>>
> > >>>> On 3/6/19 8:53 AM, Zoran Regvart wrote:
> > >>>>> Hi Cameleers,
> > >>>>> On Wed, Mar 6, 2019 at 2:03 AM Willem Jiang <wi...@gmail.com> wrote:
> > >>>>>> But I cannot find the checkstyle plugin setting with the building
> > >>>>>> tools on the master branch.
> > >>>>>>
> > >>>>>> [1]https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L407
> > >>>>> I think that points to a classpath location[1] which in turn is
> > >>>>> contained in the `camel-buildtools` module[2].
> > >>>>>
> > >>>>> I usually configure Eclipse using M2E and there's a Checkstyle
> > >>>>> extension[3] that picks up the configuration from the pom.xml file, so
> > >>>>> no need for manual setup via Ant...
> > >>>>>
> > >>>>> zoran
> > >>>>>
> > >>>>> [1] https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L399
> > >>>>> [2] https://github.com/apache/camel/tree/1697ba6074aea80fe341dd07baac4fd85165dd74/buildingtools
> > >>>>> [3] https://m2e-code-quality.github.io/m2e-code-quality/
> > >>>
> > >
> > >
>
>
>
> --
> Zoran Regvart
--
Zoran Regvart
Re: IntelliJ IDEA setup for Apache Camel
Posted by Zoran Regvart <zo...@regvart.com>.
Hi Marc,
I can do that not an issue :) I'll open an issue[1] first and let
anyone else to chime in if they wish.
zoran
[1] https://issues.apache.org/jira/browse/CAMEL-13336
On Mon, Mar 18, 2019 at 2:19 PM Marc Carter <dr...@gmail.com> wrote:
>
> Ok. Not sure if I should take that on via non-committer public PR of
> 18000 Java files?
>
> On 3/18/19 12:29 PM, Zoran Regvart wrote:
> > Hi Marc,
> > I would not mind to touch every Java file to fix the headers, that
> > should also be easily automated via `mvn license:format` after
> > changing the `header-java.txt`[1], we should also make sure that
> > Checkstyle and RAT configuration matches.
> >
> > zoran
> >
> > [1] https://github.com/apache/camel/blob/master/buildingtools/src/main/resources/header-java.txt
> >
> > On Mon, Mar 18, 2019 at 12:01 PM Marc Carter <dr...@gmail.com> wrote:
> >> Interesting one perhaps Apache knows about at a general level...
> >> Per comments on IntelliJ issue I raised:
> >> https://youtrack.jetbrains.com/issue/IDEA-208439 Java formatting amends OSS license headers as JavaDoc
> >>
> >> Camel (* and apparently many others) is mistakenly applying the *.java license header as a /** */ dangling Javadoc instead of a /* */ multi-line comment. Eclipse has a "workaround" in its formatter to skip header-comments. Options:
> >> (a) make no change
> >> I will add explicit IntellIJ formatter rules to ignore all "dangling javadocs" (overly broad but not too evil provided CheckStyle backs us up by enabling the same as a read-only verification)
> >> (b) change the header file and let Java files change "organically"
> >> Probably a terrible idea...
> >> (c) touch every source file
> >> I wouldn't have bothered raising this normally but, right now, (c) is not dissimilar to the major directory restructuring occurring in 3.0.0
> >>
> >> Marc
> >>
> >> (*) FYI
> >> https://issues.apache.org/jira/browse/HIVE-17952 Fix license headers to avoid dangling javadoc warnings
> >> https://github.com/palantir/atlasdb/issues/1693Copyright text in code should be in comment and not JavaDoc
> >> https://github.com/mycila/license-maven-plugin/issues/118 license
> >> headers for java files https://github.com/yegor256/eo/issues/109 Qulice
> >> incorrectly requires that the license text is in a Javadoc comment
> >>
> >> On 3/6/19 9:24 AM, Zoran Regvart wrote:
> >>> Hi Marc,
> >>> yes, the files in `buildingtools/src/main/resources` are used when we
> >>> run Checkstyle as a part of our build on Jenkins and during the
> >>> release.
> >>>
> >>> You can also cleanup the duplicate files, not sure why those remained there.
> >>>
> >>> Thanks :)
> >>>
> >>> zoran
> >>>
> >>> On Wed, Mar 6, 2019 at 10:22 AM Marc Carter <dr...@gmail.com> wrote:
> >>>> So I'm hearing that `buildingtools/src/main/resources` is canonical
> >>>> (including all dupe files in `buildingtools`). They have slightly
> >>>> different content and even different change histories - probably because
> >>>> of this confusion. I'm not going to check the fine detail of all of
> >>>> these though. If unofficial ones are not part of the builds, they should
> >>>> be deleted?
> >>>>
> >>>> I'm going to PR the result of these conversations along with IJ setup
> >>>> when ready
> >>>>
> >>>> Marc
> >>>>
> >>>> PS. Raised an issue on IJ code formatting as we cannot yet just "import
> >>>> the Eclipse format" because of a limitation
> >>>>
> >>>> https://youtrack.jetbrains.com/issue/IDEA-208439 Java formatting amends
> >>>> OSS license headers
> >>>>
> >>>> On 3/6/19 8:53 AM, Zoran Regvart wrote:
> >>>>> Hi Cameleers,
> >>>>> On Wed, Mar 6, 2019 at 2:03 AM Willem Jiang <wi...@gmail.com> wrote:
> >>>>>> But I cannot find the checkstyle plugin setting with the building
> >>>>>> tools on the master branch.
> >>>>>>
> >>>>>> [1]https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L407
> >>>>> I think that points to a classpath location[1] which in turn is
> >>>>> contained in the `camel-buildtools` module[2].
> >>>>>
> >>>>> I usually configure Eclipse using M2E and there's a Checkstyle
> >>>>> extension[3] that picks up the configuration from the pom.xml file, so
> >>>>> no need for manual setup via Ant...
> >>>>>
> >>>>> zoran
> >>>>>
> >>>>> [1] https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L399
> >>>>> [2] https://github.com/apache/camel/tree/1697ba6074aea80fe341dd07baac4fd85165dd74/buildingtools
> >>>>> [3] https://m2e-code-quality.github.io/m2e-code-quality/
> >>>
> >
> >
--
Zoran Regvart
Re: IntelliJ IDEA setup for Apache Camel
Posted by Marc Carter <dr...@gmail.com>.
Ok. Not sure if I should take that on via non-committer public PR of
18000 Java files?
On 3/18/19 12:29 PM, Zoran Regvart wrote:
> Hi Marc,
> I would not mind to touch every Java file to fix the headers, that
> should also be easily automated via `mvn license:format` after
> changing the `header-java.txt`[1], we should also make sure that
> Checkstyle and RAT configuration matches.
>
> zoran
>
> [1] https://github.com/apache/camel/blob/master/buildingtools/src/main/resources/header-java.txt
>
> On Mon, Mar 18, 2019 at 12:01 PM Marc Carter <dr...@gmail.com> wrote:
>> Interesting one perhaps Apache knows about at a general level...
>> Per comments on IntelliJ issue I raised:
>> https://youtrack.jetbrains.com/issue/IDEA-208439 Java formatting amends OSS license headers as JavaDoc
>>
>> Camel (* and apparently many others) is mistakenly applying the *.java license header as a /** */ dangling Javadoc instead of a /* */ multi-line comment. Eclipse has a "workaround" in its formatter to skip header-comments. Options:
>> (a) make no change
>> I will add explicit IntellIJ formatter rules to ignore all "dangling javadocs" (overly broad but not too evil provided CheckStyle backs us up by enabling the same as a read-only verification)
>> (b) change the header file and let Java files change "organically"
>> Probably a terrible idea...
>> (c) touch every source file
>> I wouldn't have bothered raising this normally but, right now, (c) is not dissimilar to the major directory restructuring occurring in 3.0.0
>>
>> Marc
>>
>> (*) FYI
>> https://issues.apache.org/jira/browse/HIVE-17952 Fix license headers to avoid dangling javadoc warnings
>> https://github.com/palantir/atlasdb/issues/1693Copyright text in code should be in comment and not JavaDoc
>> https://github.com/mycila/license-maven-plugin/issues/118 license
>> headers for java files https://github.com/yegor256/eo/issues/109 Qulice
>> incorrectly requires that the license text is in a Javadoc comment
>>
>> On 3/6/19 9:24 AM, Zoran Regvart wrote:
>>> Hi Marc,
>>> yes, the files in `buildingtools/src/main/resources` are used when we
>>> run Checkstyle as a part of our build on Jenkins and during the
>>> release.
>>>
>>> You can also cleanup the duplicate files, not sure why those remained there.
>>>
>>> Thanks :)
>>>
>>> zoran
>>>
>>> On Wed, Mar 6, 2019 at 10:22 AM Marc Carter <dr...@gmail.com> wrote:
>>>> So I'm hearing that `buildingtools/src/main/resources` is canonical
>>>> (including all dupe files in `buildingtools`). They have slightly
>>>> different content and even different change histories - probably because
>>>> of this confusion. I'm not going to check the fine detail of all of
>>>> these though. If unofficial ones are not part of the builds, they should
>>>> be deleted?
>>>>
>>>> I'm going to PR the result of these conversations along with IJ setup
>>>> when ready
>>>>
>>>> Marc
>>>>
>>>> PS. Raised an issue on IJ code formatting as we cannot yet just "import
>>>> the Eclipse format" because of a limitation
>>>>
>>>> https://youtrack.jetbrains.com/issue/IDEA-208439 Java formatting amends
>>>> OSS license headers
>>>>
>>>> On 3/6/19 8:53 AM, Zoran Regvart wrote:
>>>>> Hi Cameleers,
>>>>> On Wed, Mar 6, 2019 at 2:03 AM Willem Jiang <wi...@gmail.com> wrote:
>>>>>> But I cannot find the checkstyle plugin setting with the building
>>>>>> tools on the master branch.
>>>>>>
>>>>>> [1]https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L407
>>>>> I think that points to a classpath location[1] which in turn is
>>>>> contained in the `camel-buildtools` module[2].
>>>>>
>>>>> I usually configure Eclipse using M2E and there's a Checkstyle
>>>>> extension[3] that picks up the configuration from the pom.xml file, so
>>>>> no need for manual setup via Ant...
>>>>>
>>>>> zoran
>>>>>
>>>>> [1] https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L399
>>>>> [2] https://github.com/apache/camel/tree/1697ba6074aea80fe341dd07baac4fd85165dd74/buildingtools
>>>>> [3] https://m2e-code-quality.github.io/m2e-code-quality/
>>>
>
>
Re: IntelliJ IDEA setup for Apache Camel
Posted by Zoran Regvart <zo...@regvart.com>.
Hi Marc,
I would not mind to touch every Java file to fix the headers, that
should also be easily automated via `mvn license:format` after
changing the `header-java.txt`[1], we should also make sure that
Checkstyle and RAT configuration matches.
zoran
[1] https://github.com/apache/camel/blob/master/buildingtools/src/main/resources/header-java.txt
On Mon, Mar 18, 2019 at 12:01 PM Marc Carter <dr...@gmail.com> wrote:
>
> Interesting one perhaps Apache knows about at a general level...
> Per comments on IntelliJ issue I raised:
> https://youtrack.jetbrains.com/issue/IDEA-208439 Java formatting amends OSS license headers as JavaDoc
>
> Camel (* and apparently many others) is mistakenly applying the *.java license header as a /** */ dangling Javadoc instead of a /* */ multi-line comment. Eclipse has a "workaround" in its formatter to skip header-comments. Options:
> (a) make no change
> I will add explicit IntellIJ formatter rules to ignore all "dangling javadocs" (overly broad but not too evil provided CheckStyle backs us up by enabling the same as a read-only verification)
> (b) change the header file and let Java files change "organically"
> Probably a terrible idea...
> (c) touch every source file
> I wouldn't have bothered raising this normally but, right now, (c) is not dissimilar to the major directory restructuring occurring in 3.0.0
>
> Marc
>
> (*) FYI
> https://issues.apache.org/jira/browse/HIVE-17952 Fix license headers to avoid dangling javadoc warnings
> https://github.com/palantir/atlasdb/issues/1693Copyright text in code should be in comment and not JavaDoc
> https://github.com/mycila/license-maven-plugin/issues/118 license
> headers for java files https://github.com/yegor256/eo/issues/109 Qulice
> incorrectly requires that the license text is in a Javadoc comment
>
> On 3/6/19 9:24 AM, Zoran Regvart wrote:
> > Hi Marc,
> > yes, the files in `buildingtools/src/main/resources` are used when we
> > run Checkstyle as a part of our build on Jenkins and during the
> > release.
> >
> > You can also cleanup the duplicate files, not sure why those remained there.
> >
> > Thanks :)
> >
> > zoran
> >
> > On Wed, Mar 6, 2019 at 10:22 AM Marc Carter <dr...@gmail.com> wrote:
> >> So I'm hearing that `buildingtools/src/main/resources` is canonical
> >> (including all dupe files in `buildingtools`). They have slightly
> >> different content and even different change histories - probably because
> >> of this confusion. I'm not going to check the fine detail of all of
> >> these though. If unofficial ones are not part of the builds, they should
> >> be deleted?
> >>
> >> I'm going to PR the result of these conversations along with IJ setup
> >> when ready
> >>
> >> Marc
> >>
> >> PS. Raised an issue on IJ code formatting as we cannot yet just "import
> >> the Eclipse format" because of a limitation
> >>
> >> https://youtrack.jetbrains.com/issue/IDEA-208439 Java formatting amends
> >> OSS license headers
> >>
> >> On 3/6/19 8:53 AM, Zoran Regvart wrote:
> >>> Hi Cameleers,
> >>> On Wed, Mar 6, 2019 at 2:03 AM Willem Jiang <wi...@gmail.com> wrote:
> >>>> But I cannot find the checkstyle plugin setting with the building
> >>>> tools on the master branch.
> >>>>
> >>>> [1]https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L407
> >>> I think that points to a classpath location[1] which in turn is
> >>> contained in the `camel-buildtools` module[2].
> >>>
> >>> I usually configure Eclipse using M2E and there's a Checkstyle
> >>> extension[3] that picks up the configuration from the pom.xml file, so
> >>> no need for manual setup via Ant...
> >>>
> >>> zoran
> >>>
> >>> [1] https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L399
> >>> [2] https://github.com/apache/camel/tree/1697ba6074aea80fe341dd07baac4fd85165dd74/buildingtools
> >>> [3] https://m2e-code-quality.github.io/m2e-code-quality/
> >
> >
--
Zoran Regvart
Re: IntelliJ IDEA setup for Apache Camel
Posted by Marc Carter <dr...@gmail.com>.
Interesting one perhaps Apache knows about at a general level...
Per comments on IntelliJ issue I raised:
https://youtrack.jetbrains.com/issue/IDEA-208439 Java formatting amends OSS license headers as JavaDoc
Camel (* and apparently many others) is mistakenly applying the *.java license header as a /** */ dangling Javadoc instead of a /* */ multi-line comment. Eclipse has a "workaround" in its formatter to skip header-comments. Options:
(a) make no change
I will add explicit IntellIJ formatter rules to ignore all "dangling javadocs" (overly broad but not too evil provided CheckStyle backs us up by enabling the same as a read-only verification)
(b) change the header file and let Java files change "organically"
Probably a terrible idea...
(c) touch every source file
I wouldn't have bothered raising this normally but, right now, (c) is not dissimilar to the major directory restructuring occurring in 3.0.0
Marc
(*) FYI
https://issues.apache.org/jira/browse/HIVE-17952 Fix license headers to avoid dangling javadoc warnings
https://github.com/palantir/atlasdb/issues/1693Copyright text in code should be in comment and not JavaDoc
https://github.com/mycila/license-maven-plugin/issues/118 license
headers for java files https://github.com/yegor256/eo/issues/109 Qulice
incorrectly requires that the license text is in a Javadoc comment
On 3/6/19 9:24 AM, Zoran Regvart wrote:
> Hi Marc,
> yes, the files in `buildingtools/src/main/resources` are used when we
> run Checkstyle as a part of our build on Jenkins and during the
> release.
>
> You can also cleanup the duplicate files, not sure why those remained there.
>
> Thanks :)
>
> zoran
>
> On Wed, Mar 6, 2019 at 10:22 AM Marc Carter <dr...@gmail.com> wrote:
>> So I'm hearing that `buildingtools/src/main/resources` is canonical
>> (including all dupe files in `buildingtools`). They have slightly
>> different content and even different change histories - probably because
>> of this confusion. I'm not going to check the fine detail of all of
>> these though. If unofficial ones are not part of the builds, they should
>> be deleted?
>>
>> I'm going to PR the result of these conversations along with IJ setup
>> when ready
>>
>> Marc
>>
>> PS. Raised an issue on IJ code formatting as we cannot yet just "import
>> the Eclipse format" because of a limitation
>>
>> https://youtrack.jetbrains.com/issue/IDEA-208439 Java formatting amends
>> OSS license headers
>>
>> On 3/6/19 8:53 AM, Zoran Regvart wrote:
>>> Hi Cameleers,
>>> On Wed, Mar 6, 2019 at 2:03 AM Willem Jiang <wi...@gmail.com> wrote:
>>>> But I cannot find the checkstyle plugin setting with the building
>>>> tools on the master branch.
>>>>
>>>> [1]https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L407
>>> I think that points to a classpath location[1] which in turn is
>>> contained in the `camel-buildtools` module[2].
>>>
>>> I usually configure Eclipse using M2E and there's a Checkstyle
>>> extension[3] that picks up the configuration from the pom.xml file, so
>>> no need for manual setup via Ant...
>>>
>>> zoran
>>>
>>> [1] https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L399
>>> [2] https://github.com/apache/camel/tree/1697ba6074aea80fe341dd07baac4fd85165dd74/buildingtools
>>> [3] https://m2e-code-quality.github.io/m2e-code-quality/
>
>
Re: IntelliJ IDEA setup for Apache Camel
Posted by Zoran Regvart <zo...@regvart.com>.
Hi Marc,
yes, the files in `buildingtools/src/main/resources` are used when we
run Checkstyle as a part of our build on Jenkins and during the
release.
You can also cleanup the duplicate files, not sure why those remained there.
Thanks :)
zoran
On Wed, Mar 6, 2019 at 10:22 AM Marc Carter <dr...@gmail.com> wrote:
>
> So I'm hearing that `buildingtools/src/main/resources` is canonical
> (including all dupe files in `buildingtools`). They have slightly
> different content and even different change histories - probably because
> of this confusion. I'm not going to check the fine detail of all of
> these though. If unofficial ones are not part of the builds, they should
> be deleted?
>
> I'm going to PR the result of these conversations along with IJ setup
> when ready
>
> Marc
>
> PS. Raised an issue on IJ code formatting as we cannot yet just "import
> the Eclipse format" because of a limitation
>
> https://youtrack.jetbrains.com/issue/IDEA-208439 Java formatting amends
> OSS license headers
>
> On 3/6/19 8:53 AM, Zoran Regvart wrote:
> > Hi Cameleers,
> > On Wed, Mar 6, 2019 at 2:03 AM Willem Jiang <wi...@gmail.com> wrote:
> >> But I cannot find the checkstyle plugin setting with the building
> >> tools on the master branch.
> >>
> >> [1]https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L407
> > I think that points to a classpath location[1] which in turn is
> > contained in the `camel-buildtools` module[2].
> >
> > I usually configure Eclipse using M2E and there's a Checkstyle
> > extension[3] that picks up the configuration from the pom.xml file, so
> > no need for manual setup via Ant...
> >
> > zoran
> >
> > [1] https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L399
> > [2] https://github.com/apache/camel/tree/1697ba6074aea80fe341dd07baac4fd85165dd74/buildingtools
> > [3] https://m2e-code-quality.github.io/m2e-code-quality/
--
Zoran Regvart
Re: IntelliJ IDEA setup for Apache Camel
Posted by Marc Carter <dr...@gmail.com>.
So I'm hearing that `buildingtools/src/main/resources` is canonical
(including all dupe files in `buildingtools`). They have slightly
different content and even different change histories - probably because
of this confusion. I'm not going to check the fine detail of all of
these though. If unofficial ones are not part of the builds, they should
be deleted?
I'm going to PR the result of these conversations along with IJ setup
when ready
Marc
PS. Raised an issue on IJ code formatting as we cannot yet just "import
the Eclipse format" because of a limitation
https://youtrack.jetbrains.com/issue/IDEA-208439 Java formatting amends
OSS license headers
On 3/6/19 8:53 AM, Zoran Regvart wrote:
> Hi Cameleers,
> On Wed, Mar 6, 2019 at 2:03 AM Willem Jiang <wi...@gmail.com> wrote:
>> But I cannot find the checkstyle plugin setting with the building
>> tools on the master branch.
>>
>> [1]https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L407
> I think that points to a classpath location[1] which in turn is
> contained in the `camel-buildtools` module[2].
>
> I usually configure Eclipse using M2E and there's a Checkstyle
> extension[3] that picks up the configuration from the pom.xml file, so
> no need for manual setup via Ant...
>
> zoran
>
> [1] https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L399
> [2] https://github.com/apache/camel/tree/1697ba6074aea80fe341dd07baac4fd85165dd74/buildingtools
> [3] https://m2e-code-quality.github.io/m2e-code-quality/
Re: IntelliJ IDEA setup for Apache Camel
Posted by Zoran Regvart <zo...@regvart.com>.
Hi Cameleers,
On Wed, Mar 6, 2019 at 2:03 AM Willem Jiang <wi...@gmail.com> wrote:
> But I cannot find the checkstyle plugin setting with the building
> tools on the master branch.
>
> [1]https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L407
I think that points to a classpath location[1] which in turn is
contained in the `camel-buildtools` module[2].
I usually configure Eclipse using M2E and there's a Checkstyle
extension[3] that picks up the configuration from the pom.xml file, so
no need for manual setup via Ant...
zoran
[1] https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L399
[2] https://github.com/apache/camel/tree/1697ba6074aea80fe341dd07baac4fd85165dd74/buildingtools
[3] https://m2e-code-quality.github.io/m2e-code-quality/
--
Zoran Regvart
Re: IntelliJ IDEA setup for Apache Camel
Posted by Willem Jiang <wi...@gmail.com>.
Willem JiangTwitter: willemjiangWeibo: 姜宁willem
On Wed, Mar 6, 2019 at 12:39 AM Marc Carter <dr...@gmail.com> wrote:
>
> I took a look at that and it's helped a bit but this does need a
> retelling. For the sake of sanity, CheckStyle and Eclipse rules should
> be golden - IntelliJ has decent import system for both that can be (re)
> documented. However (isn't there always something...)
>
> a) etc/eclipse/CamelCodeFormatter.xml contains an indent of 8 which is
> obviously incorrect (clashes with CS rules). Is this the correct file?
>
> <setting id="org.eclipse.jdt.core.formatter.indentation.size" value="8"/>
>
It's wrong, do you mind send a PR for it.
> b) buildingtools/camel-checkstyle.xml differs from
> buildingtools/src/main/resources/camel-checkstyle.xml
>
> Which is correct?
It's confuse the user.
The check style file in the resource directory[1] is used in setting
up the eclipse workspace.
But I cannot find the checkstyle plugin setting with the building
tools on the master branch.
[1]https://github.com/apache/camel/blob/84c003e039e00622313d0328270c5f139b6a8821/pom.xml#L407
>
> On 3/5/19 11:45 AM, Onder SEZGIN wrote:
> > http://camel.apache.org/set-up-your-ide.html
> >
> > see this file mentioned below is on older branches on github.
> >
> > *etc/idea/settings.jar*
> >
> > On Tue, Mar 5, 2019 at 1:42 PM Marc Carter <dr...@gmail.com> wrote:
> >
> >> Official instructions for IntelliJ(*) point to files that no longer
> >> exist. I'm sure there's some history to this but it does mean I (and
> >> anyone else not using Eclipse) is missing the checkstyle and format
> >> rules that prevent poor quality checkins.
> >>
> >> I have learnt the command-line version but it's no substitute for your
> >> IDE getting the details correct as you type!
> >>
> >> ./mvnw -TC1 -pl :camel-module1,:camel-module2 -Pfastinstall -Psourcecheck
> >>
> >> Are there any newer IJ instructions or should I set this up myself?
> >>
> >> Marc
> >>
> >> (*) http://camel.apache.org/set-up-your-ide.html
> >>
> >>
> >>
> >>
Re: IntelliJ IDEA setup for Apache Camel
Posted by Marc Carter <dr...@gmail.com>.
I took a look at that and it's helped a bit but this does need a
retelling. For the sake of sanity, CheckStyle and Eclipse rules should
be golden - IntelliJ has decent import system for both that can be (re)
documented. However (isn't there always something...)
a) etc/eclipse/CamelCodeFormatter.xml contains an indent of 8 which is
obviously incorrect (clashes with CS rules). Is this the correct file?
<setting id="org.eclipse.jdt.core.formatter.indentation.size" value="8"/>
b) buildingtools/camel-checkstyle.xml differs from
buildingtools/src/main/resources/camel-checkstyle.xml
Which is correct?
On 3/5/19 11:45 AM, Onder SEZGIN wrote:
> http://camel.apache.org/set-up-your-ide.html
>
> see this file mentioned below is on older branches on github.
>
> *etc/idea/settings.jar*
>
> On Tue, Mar 5, 2019 at 1:42 PM Marc Carter <dr...@gmail.com> wrote:
>
>> Official instructions for IntelliJ(*) point to files that no longer
>> exist. I'm sure there's some history to this but it does mean I (and
>> anyone else not using Eclipse) is missing the checkstyle and format
>> rules that prevent poor quality checkins.
>>
>> I have learnt the command-line version but it's no substitute for your
>> IDE getting the details correct as you type!
>>
>> ./mvnw -TC1 -pl :camel-module1,:camel-module2 -Pfastinstall -Psourcecheck
>>
>> Are there any newer IJ instructions or should I set this up myself?
>>
>> Marc
>>
>> (*) http://camel.apache.org/set-up-your-ide.html
>>
>>
>>
>>
Re: IntelliJ IDEA setup for Apache Camel
Posted by Onder SEZGIN <on...@apache.org>.
http://camel.apache.org/set-up-your-ide.html
see this file mentioned below is on older branches on github.
*etc/idea/settings.jar*
On Tue, Mar 5, 2019 at 1:42 PM Marc Carter <dr...@gmail.com> wrote:
> Official instructions for IntelliJ(*) point to files that no longer
> exist. I'm sure there's some history to this but it does mean I (and
> anyone else not using Eclipse) is missing the checkstyle and format
> rules that prevent poor quality checkins.
>
> I have learnt the command-line version but it's no substitute for your
> IDE getting the details correct as you type!
>
> ./mvnw -TC1 -pl :camel-module1,:camel-module2 -Pfastinstall -Psourcecheck
>
> Are there any newer IJ instructions or should I set this up myself?
>
> Marc
>
> (*) http://camel.apache.org/set-up-your-ide.html
>
>
>
>