You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mahesh Reddy (Code Review)" <ge...@cloudera.org> on 2024/01/05 07:11:35 UTC
[kudu-CR](branch-1.17.x) KUDU-3252: Follow up to replica placement bug
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/20861
to review the following change.
Change subject: KUDU-3252: Follow up to replica placement bug
......................................................................
KUDU-3252: Follow up to replica placement bug
This patch addresses the feedback left on
patch [1].
ReservoirSample is refactored to accept an
unsigned integer rather than a signed integer.
A new test is added to verify the functionality
of the tiebreaker scenarios of
PlacementPolicy::SelectReplica().
[1] https://github.com/apache/kudu/commit/a84c8376a
Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86
Reviewed-on: http://gerrit.cloudera.org:8080/20827
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 2810e635cc72aa5279a9dc787b6becad6e0098a9)
---
M src/kudu/master/placement_policy-test.cc
M src/kudu/master/placement_policy.cc
M src/kudu/util/random_util.h
3 files changed, 68 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/20861/1
--
To view, visit http://gerrit.cloudera.org:8080/20861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86
Gerrit-Change-Number: 20861
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20861 )
Change subject: KUDU-3532: Follow up to replica placement bug
......................................................................
Patch Set 2: Verified+1
unrelated test failures
--
To view, visit http://gerrit.cloudera.org:8080/20861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86
Gerrit-Change-Number: 20861
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Jan 2024 04:45:20 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20861 )
Change subject: KUDU-3532: Follow up to replica placement bug
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86
Gerrit-Change-Number: 20861
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Jan 2024 19:28:07 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20861 )
Change subject: KUDU-3532: Follow up to replica placement bug
......................................................................
KUDU-3532: Follow up to replica placement bug
This patch addresses the feedback left on
patch [1].
ReservoirSample is refactored to accept an
unsigned integer rather than a signed integer.
A new test is added to verify the functionality
of the tiebreaker scenarios of
PlacementPolicy::SelectReplica().
[1] https://github.com/apache/kudu/commit/a84c8376a
Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86
Reviewed-on: http://gerrit.cloudera.org:8080/20827
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 2810e635cc72aa5279a9dc787b6becad6e0098a9)
Reviewed-on: http://gerrit.cloudera.org:8080/20861
---
M src/kudu/master/placement_policy-test.cc
M src/kudu/master/placement_policy.cc
M src/kudu/util/random_util.h
3 files changed, 68 insertions(+), 21 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/20861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86
Gerrit-Change-Number: 20861
Gerrit-PatchSet: 3
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR](branch-1.17.x) KUDU-3252: Follow up to replica placement bug
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20861 )
Change subject: KUDU-3252: Follow up to replica placement bug
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20861/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20861/1//COMMIT_MSG@7
PS1, Line 7: KUDU-3252
KUDU-3532
--
To view, visit http://gerrit.cloudera.org:8080/20861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86
Gerrit-Change-Number: 20861
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 05 Jan 2024 16:36:04 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20861 )
Change subject: KUDU-3532: Follow up to replica placement bug
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20861/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20861/1//COMMIT_MSG@7
PS1, Line 7: KUDU-3532
> KUDU-3532
Done
--
To view, visit http://gerrit.cloudera.org:8080/20861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86
Gerrit-Change-Number: 20861
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Jan 2024 19:02:16 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20861
to look at the new patch set (#2).
Change subject: KUDU-3532: Follow up to replica placement bug
......................................................................
KUDU-3532: Follow up to replica placement bug
This patch addresses the feedback left on
patch [1].
ReservoirSample is refactored to accept an
unsigned integer rather than a signed integer.
A new test is added to verify the functionality
of the tiebreaker scenarios of
PlacementPolicy::SelectReplica().
[1] https://github.com/apache/kudu/commit/a84c8376a
Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86
Reviewed-on: http://gerrit.cloudera.org:8080/20827
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 2810e635cc72aa5279a9dc787b6becad6e0098a9)
---
M src/kudu/master/placement_policy-test.cc
M src/kudu/master/placement_policy.cc
M src/kudu/util/random_util.h
3 files changed, 68 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/20861/2
--
To view, visit http://gerrit.cloudera.org:8080/20861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86
Gerrit-Change-Number: 20861
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3532: Follow up to replica placement bug
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86
Gerrit-Change-Number: 20861
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>