You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/09/23 14:54:08 UTC
[PR] [SPARK-59743] Consolidate `Helm Tests` matrix jobs into a single job [spark-kubernetes-operator]
dongjoon-hyun opened a new pull request, #874:
URL: https://github.com/apache/spark-kubernetes-operator/pull/874
### What changes were proposed in this pull request?
This PR aims to consolidate the four `Helm Tests` matrix jobs (`configmap-metadata`, `kueue`, `network-policy`, `operator-command`) into a single job.
- Remove the `strategy.matrix` and pin `kubernetes-version` to `1.37.0`.
- Install Kueue once unconditionally.
- Run each test group sequentially in a loop: `helm install` → `helm test` → `helm uninstall`, grouping the log per test group via `::group::`.
- Move the `Verify Kueue RBAC is denied by default` check into the loop for the `kueue` group.
- Wait for the operator pod to be deleted after `helm uninstall` so that the next group's tests do not select a terminating operator pod by its labels.
### Why are the changes needed?
Each test group only differs by a single `values.yaml` file, but every matrix job pays the full cost of provisioning Minikube and downloading and loading the operator image. Running them in one job reduces the number of GitHub Actions runners from 4 to 1 while keeping each test group isolated in its own Helm release.
### Does this PR introduce _any_ user-facing change?
No. This is a CI-only change.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59743] Consolidate `Helm Tests` matrix jobs into a single job [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #874:
URL: https://github.com/apache/spark-kubernetes-operator/pull/874#issuecomment-5797507859
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59743] Consolidate `Helm Tests` matrix jobs into a single job [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #874: [SPARK-59743] Consolidate `Helm Tests` matrix jobs into a single job
URL: https://github.com/apache/spark-kubernetes-operator/pull/874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59743] Consolidate `Helm Tests` matrix jobs into a single job [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #874:
URL: https://github.com/apache/spark-kubernetes-operator/pull/874#issuecomment-5797502151
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59743] Consolidate `Helm Tests` matrix jobs into a single job [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #874:
URL: https://github.com/apache/spark-kubernetes-operator/pull/874#issuecomment-5797221583
Thank you, @peter-toth !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org