You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/01/11 23:55:01 UTC
[GitHub] michaelsembwever commented on a change in pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible
michaelsembwever commented on a change in pull request #737: Remove OJDBC and resin artifacts from ci-dependencies driectory as they as not Apache license compatible
URL: https://github.com/apache/incubator-skywalking/pull/737#discussion_r161109028
##########
File path: apm-sniffer/apm-sdk-plugin/pom.xml
##########
@@ -202,4 +200,31 @@
</plugin>
</plugins>
</build>
+
+ <profiles>
+ <profile>
+ <!-- ojdbc is not Apache license compatible, so it must be manually downloaded first -->
+ <id>include-ojdbc</id>
+ <activation>
+ <file>
+ <exists>${basedir}/../../ci-dependencies/ojdbc14-10.2.0.4.0.jar</exists>
+ </file>
+ </activation>
+ <modules>
+ <module>oracle-10.x-plugin</module>
+ </modules>
+ </profile>
+ <profile>
+ <!-- resin is not Apache license compatible, so it must be manually downloaded first -->
+ <id>include-resin</id>
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services