[GitHub] [pulsar] Jason918 commented on a diff in pull request #16325: [fix][broker] fix the local police IsolationGroups cover the defaultIsolationGroups when init managedLedger bookkeeper client

[GitBox <gi...@apache.org>]

Jason918 commented on code in PR #16325:
URL: https://github.com/apache/pulsar/pull/16325#discussion_r931760099


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/BookKeeperClientFactoryImpl.java:
##########
@@ -71,9 +71,7 @@ public BookKeeper create(ServiceConfiguration conf, MetadataStoreExtended store,
         MetadataDrivers.registerClientDriver("metadata-store", PulsarMetadataClientDriver.class);
 
         ClientConfiguration bkConf = createBkClientConfiguration(store, conf);
-        if (properties != null) {
-            properties.forEach((key, value) -> bkConf.setProperty(key, value));
-        }
+

Review Comment:
   This seems like a breaking change. We are not able to set `bkConf` through `properties` at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org