You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/31 15:28:10 UTC
[GitHub] [arrow] lidavidm opened a new pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close
lidavidm opened a new pull request #12302:
URL: https://github.com/apache/arrow/pull/12302
Add a method to explicitly close FlightClient in anticipation of implementing alternative transports which may need this, and to provide an interface for things like ARROW-15473. Because this did not exist before, it is implicitly called by the destructor. For gRPC, this is a no-op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12302:
URL: https://github.com/apache/arrow/pull/12302#issuecomment-1034447214
Benchmark runs are scheduled for baseline = e4f658761ffec9a69fe1b3ab5e2b01b27a87493c and contender = 647371b504df166860bd33346dcbd962c85e046f. 647371b504df166860bd33346dcbd962c85e046f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/063460c922654baa9a44ea25d3baa96f...2c3039ae2301425a82ce12f760d87869/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f2121e5e2d614fdd989d281ff7b6d4e5...a8785cff8f83466194bd1d0b7fe3695f/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d775332205974dc789fac55f5b402e0e...f296ff7c5cc1455d807346d1119666fc/)
[Finished :arrow_down:0.74% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2759033c429d4d4e84868e6c5faed7f5...e31df06a89634fe8866a6f7c2a76748f/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 closed pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close
Posted by GitBox <gi...@apache.org>.
cyb70289 closed pull request #12302:
URL: https://github.com/apache/arrow/pull/12302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #12302:
URL: https://github.com/apache/arrow/pull/12302#issuecomment-1034404190
@kou, will you have a look at GLib related changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12302:
URL: https://github.com/apache/arrow/pull/12302#discussion_r802804968
##########
File path: cpp/src/arrow/flight/client.h
##########
@@ -323,8 +323,19 @@ class ARROW_FLIGHT_EXPORT FlightClient {
return DoExchange({}, descriptor, writer, reader);
}
+ /// \brief Explicitly shut down and clean up the client.
+ ///
+ /// For backwards compatibility, this will be implicitly called by
+ /// the destructor if not already called, but this gives the
+ /// application no chance to handle errors, so it is recommended to
+ /// explicitly close the client.
+ ///
+ /// \since 8.0.0
+ Status Close();
+
private:
FlightClient();
+ Status CheckOpen();
Review comment:
Ah whoops, fixed - thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12302:
URL: https://github.com/apache/arrow/pull/12302#issuecomment-1034447214
Benchmark runs are scheduled for baseline = e4f658761ffec9a69fe1b3ab5e2b01b27a87493c and contender = 647371b504df166860bd33346dcbd962c85e046f. 647371b504df166860bd33346dcbd962c85e046f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/063460c922654baa9a44ea25d3baa96f...2c3039ae2301425a82ce12f760d87869/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f2121e5e2d614fdd989d281ff7b6d4e5...a8785cff8f83466194bd1d0b7fe3695f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d775332205974dc789fac55f5b402e0e...f296ff7c5cc1455d807346d1119666fc/)
[Finished :arrow_down:0.74% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2759033c429d4d4e84868e6c5faed7f5...e31df06a89634fe8866a6f7c2a76748f/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12302:
URL: https://github.com/apache/arrow/pull/12302#issuecomment-1034447214
Benchmark runs are scheduled for baseline = e4f658761ffec9a69fe1b3ab5e2b01b27a87493c and contender = 647371b504df166860bd33346dcbd962c85e046f. 647371b504df166860bd33346dcbd962c85e046f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/063460c922654baa9a44ea25d3baa96f...2c3039ae2301425a82ce12f760d87869/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f2121e5e2d614fdd989d281ff7b6d4e5...a8785cff8f83466194bd1d0b7fe3695f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d775332205974dc789fac55f5b402e0e...f296ff7c5cc1455d807346d1119666fc/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2759033c429d4d4e84868e6c5faed7f5...e31df06a89634fe8866a6f7c2a76748f/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12302:
URL: https://github.com/apache/arrow/pull/12302#issuecomment-1034447214
Benchmark runs are scheduled for baseline = e4f658761ffec9a69fe1b3ab5e2b01b27a87493c and contender = 647371b504df166860bd33346dcbd962c85e046f. 647371b504df166860bd33346dcbd962c85e046f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/063460c922654baa9a44ea25d3baa96f...2c3039ae2301425a82ce12f760d87869/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f2121e5e2d614fdd989d281ff7b6d4e5...a8785cff8f83466194bd1d0b7fe3695f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d775332205974dc789fac55f5b402e0e...f296ff7c5cc1455d807346d1119666fc/)
[Finished :arrow_down:0.74% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2759033c429d4d4e84868e6c5faed7f5...e31df06a89634fe8866a6f7c2a76748f/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12302:
URL: https://github.com/apache/arrow/pull/12302#issuecomment-1034447214
Benchmark runs are scheduled for baseline = e4f658761ffec9a69fe1b3ab5e2b01b27a87493c and contender = 647371b504df166860bd33346dcbd962c85e046f. 647371b504df166860bd33346dcbd962c85e046f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/063460c922654baa9a44ea25d3baa96f...2c3039ae2301425a82ce12f760d87869/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f2121e5e2d614fdd989d281ff7b6d4e5...a8785cff8f83466194bd1d0b7fe3695f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d775332205974dc789fac55f5b402e0e...f296ff7c5cc1455d807346d1119666fc/)
[Finished :arrow_down:0.74% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2759033c429d4d4e84868e6c5faed7f5...e31df06a89634fe8866a6f7c2a76748f/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12302:
URL: https://github.com/apache/arrow/pull/12302#issuecomment-1025893827
https://issues.apache.org/jira/browse/ARROW-15487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12302:
URL: https://github.com/apache/arrow/pull/12302#issuecomment-1034447214
Benchmark runs are scheduled for baseline = e4f658761ffec9a69fe1b3ab5e2b01b27a87493c and contender = 647371b504df166860bd33346dcbd962c85e046f. 647371b504df166860bd33346dcbd962c85e046f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/063460c922654baa9a44ea25d3baa96f...2c3039ae2301425a82ce12f760d87869/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f2121e5e2d614fdd989d281ff7b6d4e5...a8785cff8f83466194bd1d0b7fe3695f/)
[Scheduled :warning: ursa-i9-9960x is offline.] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d775332205974dc789fac55f5b402e0e...f296ff7c5cc1455d807346d1119666fc/)
[Finished :arrow_down:0.74% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2759033c429d4d4e84868e6c5faed7f5...e31df06a89634fe8866a6f7c2a76748f/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12302:
URL: https://github.com/apache/arrow/pull/12302#issuecomment-1034447214
Benchmark runs are scheduled for baseline = e4f658761ffec9a69fe1b3ab5e2b01b27a87493c and contender = 647371b504df166860bd33346dcbd962c85e046f. 647371b504df166860bd33346dcbd962c85e046f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/063460c922654baa9a44ea25d3baa96f...2c3039ae2301425a82ce12f760d87869/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f2121e5e2d614fdd989d281ff7b6d4e5...a8785cff8f83466194bd1d0b7fe3695f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d775332205974dc789fac55f5b402e0e...f296ff7c5cc1455d807346d1119666fc/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2759033c429d4d4e84868e6c5faed7f5...e31df06a89634fe8866a6f7c2a76748f/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a change in pull request #12302: ARROW-15487: [FlightRPC][C++][GLib][Python][R] Implement FlightClient::Close
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #12302:
URL: https://github.com/apache/arrow/pull/12302#discussion_r801236950
##########
File path: cpp/src/arrow/flight/client.h
##########
@@ -323,8 +323,19 @@ class ARROW_FLIGHT_EXPORT FlightClient {
return DoExchange({}, descriptor, writer, reader);
}
+ /// \brief Explicitly shut down and clean up the client.
+ ///
+ /// For backwards compatibility, this will be implicitly called by
+ /// the destructor if not already called, but this gives the
+ /// application no chance to handle errors, so it is recommended to
+ /// explicitly close the client.
+ ///
+ /// \since 8.0.0
+ Status Close();
+
private:
FlightClient();
+ Status CheckOpen();
Review comment:
Nit: append `const`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org