You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/29 07:09:44 UTC
[GitHub] [incubator-nuttx-apps] pussuw opened a new pull request #946: Fix link error due to missing libapps.a in KERNEL build
pussuw opened a new pull request #946:
URL: https://github.com/apache/incubator-nuttx-apps/pull/946
## Summary
The import target for kernel build now fails, due to setting libapps.a
as the default value for the BIN variable.
The fail happens when the ELFLD function passes the LDLIBS parameter
(which contains BIN / libapps.a) for the linker. There is no rule to
create libapps.a in the case of the kernel build, so the linker gives
an error due to it being missing.
This commit patches this behavior so that BIN is not appended to
LDLIBS. Another option would be to implement a dummy rule to create
libapps.a, but looking at the git history this is no longer wanted
behavior, thus the error is patched like this.
## Impact
Should fix the ELFLD function / linkage when using CONFIG_BUILD_KERNEL
## Testing
Tested that it builds. Created a ROMFS image with the .elf binaries. Did _not_ test that the elf files themselves work / contain a valid application (elfloader does work however).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pussuw commented on pull request #946: Fix link error due to missing libapps.a in KERNEL build
Posted by GitBox <gi...@apache.org>.
pussuw commented on pull request #946:
URL: https://github.com/apache/incubator-nuttx-apps/pull/946#issuecomment-1002429260
I'm not 100% sure this is the correct way to fix the ELFLD linkage. I tried to follow the git history and the modifications made to the build system but I don't claim to fully understand how this is supposed to work.
The patch itself might just hide a problem I'm not aware of, and the actual solution / fix is implicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #946: Fix link error due to missing libapps.a in KERNEL build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #946:
URL: https://github.com/apache/incubator-nuttx-apps/pull/946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #946: Fix link error due to missing libapps.a in KERNEL build
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #946:
URL: https://github.com/apache/incubator-nuttx-apps/pull/946#issuecomment-1002580701
> I'm not 100% sure this is the correct way to fix the ELFLD linkage. I tried to follow the git history and the modifications made to the build system but I don't claim to fully understand how this is supposed to work.
>
> The patch itself might just hide a problem I'm not aware of, and the actual solution / fix is implicit.
Since the kernel mode is seldom used, let's trust your change and see other user feedback in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org