[GitHub] [kafka] vvcephei commented on pull request #12672: KAFKA-14247: Consumer background thread base implementation

[GitBox <gi...@apache.org>]

vvcephei commented on PR #12672:
URL: https://github.com/apache/kafka/pull/12672#issuecomment-1284700265

   Hey, @philipnee, @guozhangwang isn't available for reviews right now, so I'll pick it up.
   
   I reviewed it, and it all looks good to me. I had a large number of code convention corrections, so I just went ahead and applied the changes, rather than peppering you with nitpicks. I hope that's ok.
   
   Generally:
   * please use `final` when it can be used
   * indent 4 spaces instead of 8
   * when a method call has too many args to fit within the line length limit, please break it up into one-arg-per-line, rather than just breaking the args at an arbitrary point.
   
   I know that's all arbitrary, and that there are merits to doing things other ways; I'm just trying to keep these files in line with the rest of AK.
   
   Thanks! Once the tests pass, I'll go ahead and merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org