You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/23 23:08:32 UTC

[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #9357: Adding requirements-local.txt support

craig-rueda commented on a change in pull request #9357: Adding requirements-local.txt support
URL: https://github.com/apache/incubator-superset/pull/9357#discussion_r396811059
 
 

 ##########
 File path: Dockerfile
 ##########
 @@ -114,9 +114,10 @@ ENTRYPOINT ["/usr/bin/docker-entrypoint.sh"]
 ######################################################################
 FROM lean AS dev
 
-COPY ./requirements-dev.txt ./docker/requirements-extra.txt /app/
+COPY ./requirements-dev.txt ./docker/requirements* /app/
 
 USER root
 RUN cd /app \
-    && pip install --no-cache -r requirements-dev.txt -r requirements-extra.txt
+    && pip install --no-cache -r requirements-dev.txt -r requirements-extra.txt \
 
 Review comment:
   Yep, we don't want local users' changes being managed in Git

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org