You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Ziwei Liu (Jira)" <ji...@apache.org> on 2022/01/13 11:26:00 UTC
[jira] [Updated] (CALCITE-4983) When using mv rewriting, if aggregate has grouping sets, not handle the query's condition properly.
[ https://issues.apache.org/jira/browse/CALCITE-4983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ziwei Liu updated CALCITE-4983:
-------------------------------
Summary: When using mv rewriting, if aggregate has grouping sets, not handle the query's condition properly. (was: In SubstitutionVisitor's unifyAggregates, if Aggregate has grouping sets, we need to handle the condition needs to pull up.)
> When using mv rewriting, if aggregate has grouping sets, not handle the query's condition properly.
> ---------------------------------------------------------------------------------------------------
>
> Key: CALCITE-4983
> URL: https://issues.apache.org/jira/browse/CALCITE-4983
> Project: Calcite
> Issue Type: Bug
> Reporter: Ziwei Liu
> Assignee: Ziwei Liu
> Priority: Major
>
> In method unifyAggregates, if agg using grouping sets, doesn't handle the condition need to pull up.
> Here is the code:
> {code:java}
> if (targetGroupGenAggCalls.isEmpty()) {
> List<RexNode> compenProjs = MutableRels.createProjectExprs(target, projects);
> RexProgram compenRexProgram = RexProgram.create(
> target.rowType, compenProjs, targetCond, query.rowType, rexBuilder);
> result = MutableCalc.of(target, compenRexProgram);
> } else {
> // here has a problem: doesn't handle the targetCond
> result = MutableAggregate.of(target,
> target.groupSet, target.groupSets, targetGroupGenAggCalls);
> } {code}
> Here is an example:
> {code:java}
> mv: select empid, deptno from emps group by grouping sets ((empid, deptno),(empid))
> sql: select empid, count(distinct deptno) from emps where empid>100
> group by grouping sets ((empid, deptno), (empid)) {code}
> the result plan is:
> {code:java}
> LogicalCalc(expr#0..2=[{inputs}], deptno=[$t1], EXPR$1=[$t2])
> LogicalAggregate(group=[{0, 1}], groups=[[{0, 1}, {0}]], EXPR$1=[COUNT(DISTINCT $1)])
> EnumerableTableScan(table=[[hr, MV0]]) {code}
> We can see that this plan doesn't handle the condition empid>100
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)