You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Michael Osipov (JIRA)" <ji...@apache.org> on 2019/01/23 10:12:00 UTC

[jira] [Comment Edited] (MSHARED-796) use java.specification.version instead of java.version in Build-Jdk manifest entry

    [ https://issues.apache.org/jira/browse/MSHARED-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749239#comment-16749239 ] 

Michael Osipov edited comment on MSHARED-796 at 1/23/19 10:11 AM:
------------------------------------------------------------------

we teach them that java.specification.version is really something useful, because it's key to reproducibility
I'll merge this and we can continue on other fields and improvements


was (Author: hboutemy):
we learn them that java.specification.version is really something useful, because it's key to reproducibility
I'll merge this and we can continue on other fields and improvements

> use java.specification.version instead of java.version in Build-Jdk manifest entry
> ----------------------------------------------------------------------------------
>
>                 Key: MSHARED-796
>                 URL: https://issues.apache.org/jira/browse/MSHARED-796
>             Project: Maven Shared Components
>          Issue Type: Wish
>          Components: maven-archiver
>    Affects Versions: maven-archiver-3.3.0
>            Reporter: Hervé Boutemy
>            Assignee: Hervé Boutemy
>            Priority: Major
>             Fix For: maven-archiver-3.3.1
>
>
> as part or reproducible builds efforts, we're removing manifest entries that are hard to reproduce and do not add much value.
> In MSHARED-661, we removed "Built-By: <username>" entry, but decided to keep "Build-Jdk" entry
> the idea here is not to remove "Build-Jdk" entry but to replace its value from too much detailed java.version system property (which details the patch level) to java.specification.version: the specification has an impact on the generated bytecode, then is useful to keep, but at least we'll avoid patch level information



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)