[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6733: Spark-2.4: Handle no-op for rewrite manifests action

["ajantha-bhat (via GitHub)" <gi...@apache.org>]

ajantha-bhat commented on code in PR #6733:
URL: https://github.com/apache/iceberg/pull/6733#discussion_r1095435003


##########
spark/v2.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteManifestsAction.java:
##########
@@ -478,6 +492,33 @@ public void testRewriteManifestsWithPredicate() throws IOException {
     Assert.assertEquals("Rows must match", expectedRecords, actualRecords);
   }
 
+  @Test
+  public void testRewriteManifestsNoOp() throws IOException {

Review Comment:
   This is an additional test case for the scenario which was covered by spark procedure in 3.1 and above spark versions. 
   
   Rest of the changes in the PR is same as #6695 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org