Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant /taskdefs TaskOutputStream.java

[ru...@us.ibm.com]

> Modified:    src/main/org/apache/tools/ant Project.java
>                       ProjectHelper.java
> Added:       src/main/org/apache/tools/ant/taskdefs TaskOutputStream.java
> Removed:     src/main/org/apache/tools/ant TaskOutputStream.java
> Log:
> Various cleanups
> 1) Nomenclature: nested elements, not nested properties
> 2) Run task instead of

Oops.  Hit the wrong key and got half of the commit message out there.

2) Run task directly instead of by name
3) Move TaskOutputStream to the directory named in the package statement
4) Provide the task name in configuration/init generated log messages

- Sam Ruby

RE: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs TaskOutputStream.java

[Conor MacNeill <co...@cortexebusiness.com.au>]

Sam,

Sorry - should have checked the package for TaskOutputStream. I put it where
I thought it should go. As this is not supposed to be specific to a single
task, I view it as part of the ant infrastructure and believe it should be
in the core package rather than the taskdefs package.

Also I don't really agree with the concept of a "current task". When I can
get async tasks in there may be more than one current task. I would rather
see each task identify itself when logging messages.

Thoughts?

Conor

--
Conor MacNeill
conor@cortexebusiness.com.au
Cortex eBusiness
http://www.cortexebusiness.com.au

> -----Original Message-----
> From: rubys@us.ibm.com [mailto:rubys@us.ibm.com]
> Sent: Wednesday, 5 July 2000 4:44
> To: ant-dev@jakarta.apache.org
> Subject: Re: cvs commit:
> jakarta-ant/src/main/org/apache/tools/ant/taskdefs TaskOutputStream.java
>
>
>
>
> > Modified:    src/main/org/apache/tools/ant Project.java
> >                       ProjectHelper.java
> > Added:       src/main/org/apache/tools/ant/taskdefs
> TaskOutputStream.java
> > Removed:     src/main/org/apache/tools/ant TaskOutputStream.java
> > Log:
> > Various cleanups
> > 1) Nomenclature: nested elements, not nested properties
> > 2) Run task instead of
>
> Oops.  Hit the wrong key and got half of the commit message out there.
>
> 2) Run task directly instead of by name
> 3) Move TaskOutputStream to the directory named in the package statement
> 4) Provide the task name in configuration/init generated log messages
>
> - Sam Ruby
>
>
>