You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rd...@apache.org on 2007/08/04 10:39:43 UTC
svn commit: r562674 - in /james/server/trunk:
imap-mailbox-processor-function/src/main/java/org/apache/james/imapserver/processor/imap4rev1/
phoenix-deployment/src/test/org/apache/james/imapserver/util/
torque-mailboxmanager-function/src/main/java/org/...
Author: rdonkin
Date: Sat Aug 4 01:39:43 2007
New Revision: 562674
URL: http://svn.apache.org/viewvc?view=rev&rev=562674
Log:
More correct not to send recent flag.
Modified:
james/server/trunk/imap-mailbox-processor-function/src/main/java/org/apache/james/imapserver/processor/imap4rev1/AbstractMailboxSelectionProcessor.java
james/server/trunk/phoenix-deployment/src/test/org/apache/james/imapserver/util/UnsolicitedResponseGenerator.java
james/server/trunk/torque-mailboxmanager-function/src/main/java/org/apache/james/mailboxmanager/torque/TorqueMailbox.java
Modified: james/server/trunk/imap-mailbox-processor-function/src/main/java/org/apache/james/imapserver/processor/imap4rev1/AbstractMailboxSelectionProcessor.java
URL: http://svn.apache.org/viewvc/james/server/trunk/imap-mailbox-processor-function/src/main/java/org/apache/james/imapserver/processor/imap4rev1/AbstractMailboxSelectionProcessor.java?view=diff&rev=562674&r1=562673&r2=562674
==============================================================================
--- james/server/trunk/imap-mailbox-processor-function/src/main/java/org/apache/james/imapserver/processor/imap4rev1/AbstractMailboxSelectionProcessor.java (original)
+++ james/server/trunk/imap-mailbox-processor-function/src/main/java/org/apache/james/imapserver/processor/imap4rev1/AbstractMailboxSelectionProcessor.java Sat Aug 4 01:39:43 2007
@@ -57,6 +57,7 @@
String fullMailboxName = buildFullName(session, mailboxName);
selectMailbox(fullMailboxName, session, isExamine);
ImapMailboxSession mailbox = ImapSessionUtils.getMailbox(session);
+ // TODO: compact this into a single API call for meta-data about the repository
final Flags permanentFlags = mailbox.getPermanentFlags();
final boolean writeable = mailbox.isWriteable();
final boolean resetRecent = !isExamine;
Modified: james/server/trunk/phoenix-deployment/src/test/org/apache/james/imapserver/util/UnsolicitedResponseGenerator.java
URL: http://svn.apache.org/viewvc/james/server/trunk/phoenix-deployment/src/test/org/apache/james/imapserver/util/UnsolicitedResponseGenerator.java?view=diff&rev=562674&r1=562673&r2=562674
==============================================================================
--- james/server/trunk/phoenix-deployment/src/test/org/apache/james/imapserver/util/UnsolicitedResponseGenerator.java (original)
+++ james/server/trunk/phoenix-deployment/src/test/org/apache/james/imapserver/util/UnsolicitedResponseGenerator.java Sat Aug 4 01:39:43 2007
@@ -64,7 +64,7 @@
public void addFlags()
{
responseSet
- .add("* FLAGS (\\Answered \\Deleted \\Draft \\Flagged \\Recent \\Seen)");
+ .add("* FLAGS (\\Answered \\Deleted \\Draft \\Flagged \\Seen)");
}
public void addUidValidity(long uidv)
@@ -84,7 +84,7 @@
public void addPermanentFlags()
{
responseSet
- .add("* OK [PERMANENTFLAGS (\\Answered \\Deleted \\Draft \\Flagged \\Recent \\Seen)]");
+ .add("* OK [PERMANENTFLAGS (\\Answered \\Deleted \\Draft \\Flagged \\Seen)]");
}
public Set getResponseSet()
Modified: james/server/trunk/torque-mailboxmanager-function/src/main/java/org/apache/james/mailboxmanager/torque/TorqueMailbox.java
URL: http://svn.apache.org/viewvc/james/server/trunk/torque-mailboxmanager-function/src/main/java/org/apache/james/mailboxmanager/torque/TorqueMailbox.java?view=diff&rev=562674&r1=562673&r2=562674
==============================================================================
--- james/server/trunk/torque-mailboxmanager-function/src/main/java/org/apache/james/mailboxmanager/torque/TorqueMailbox.java (original)
+++ james/server/trunk/torque-mailboxmanager-function/src/main/java/org/apache/james/mailboxmanager/torque/TorqueMailbox.java Sat Aug 4 01:39:43 2007
@@ -68,8 +68,6 @@
private MailboxRow mailboxRow;
- private Flags permanentFlags;
-
private UidChangeTracker tracker;
private MailboxEventDispatcher eventDispatcher = new MailboxEventDispatcher();
@@ -329,15 +327,12 @@
public synchronized Flags getPermanentFlags() {
- if (permanentFlags == null) {
- permanentFlags = new Flags();
- permanentFlags.add(Flags.Flag.ANSWERED);
- permanentFlags.add(Flags.Flag.DELETED);
- permanentFlags.add(Flags.Flag.DRAFT);
- permanentFlags.add(Flags.Flag.FLAGGED);
- permanentFlags.add(Flags.Flag.RECENT);
- permanentFlags.add(Flags.Flag.SEEN);
- }
+ Flags permanentFlags = new Flags();
+ permanentFlags.add(Flags.Flag.ANSWERED);
+ permanentFlags.add(Flags.Flag.DELETED);
+ permanentFlags.add(Flags.Flag.DRAFT);
+ permanentFlags.add(Flags.Flag.FLAGGED);
+ permanentFlags.add(Flags.Flag.SEEN);
return permanentFlags;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org