Re: [PR] Fixes:#7837: Add isolationMethods and vlan to TrafficTypeResponse [cloudstack]

["madhukar93 (via GitHub)" <gi...@apache.org>]

madhukar93 commented on code in PR #8151:
URL: https://github.com/apache/cloudstack/pull/8151#discussion_r1375238124


##########
api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListTrafficTypesCmd.java:
##########
@@ -27,14 +27,13 @@
 import org.apache.cloudstack.api.Parameter;
 import org.apache.cloudstack.api.response.ListResponse;
 import org.apache.cloudstack.api.response.PhysicalNetworkResponse;
-import org.apache.cloudstack.api.response.ProviderResponse;
 import org.apache.cloudstack.api.response.TrafficTypeResponse;
 
 import com.cloud.network.PhysicalNetworkTrafficType;
 import com.cloud.user.Account;
 import com.cloud.utils.Pair;
 
-@APICommand(name = "listTrafficTypes", description = "Lists traffic types of a given physical network.", responseObject = ProviderResponse.class, since = "3.0.0",
+@APICommand(name = "listTrafficTypes", description = "Lists traffic types of a given physical network.", responseObject = TrafficTypeResponse.class, since = "3.0.0",

Review Comment:
   @rohityadavcloud noticed that the python client generation for `listTrafficTypes` (tools/marvin/marvin/cloudstackAPI/listTrafficTypes.py) did not match the fields in the `TrafficTypeResponse`, while exploring marvin.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org