You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rekhajoshm <gi...@git.apache.org> on 2016/05/16 21:14:29 UTC
[GitHub] flink pull request: [FLINK-2829] Confusing error message when Flin...
GitHub user rekhajoshm opened a pull request:
https://github.com/apache/flink/pull/1993
[FLINK-2829] Confusing error message when Flink cannot create enough task threads
[FLINK-2829] Confusing error message when Flink cannot create enough task threads
Clarifying the flink runtime error message on slot details on make sense for user facing them when Flink cannot create enough task threads.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rekhajoshm/flink FLINK-2829
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1993.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1993
----
commit b1f4c11f1878d53656c9ca49c6912a95a449f18e
Author: Joshi <re...@gmail.com>
Date: 2016-05-16T21:14:23Z
[FLINK-2829] Clarifying error message when Flink cannot create enough task threads
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2829] Confusing error message when Flin...
Posted by rekhajoshm <gi...@git.apache.org>.
Github user rekhajoshm commented on the pull request:
https://github.com/apache/flink/pull/1993#issuecomment-219816708
thanks @StephanEwen @gyfora @rmetzger updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2829] Confusing error message when Flin...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1993#issuecomment-221861642
Thanks for the bug fix!
Looks good, merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2829] Confusing error message when Flin...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1993#issuecomment-219813882
I agree with Gyula, the problem was a different one.
There is a chance that the issue is fixed already. From the current code it looks as if the exceptions on thread start are properly propagated and thrown and logged on the JobManager now.
In order to close this issue, we should, however, improve the error message in case an unexpected answer is returned while the task is submitted. `Execution.java`, line 407, should add the actual object to the message.
@rekhajoshm Would you update the pull request to that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2829] Confusing error message when Flin...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1993#issuecomment-219698527
Thank you for opening a pull request.
@gyfora can you validate if this is the exception you'd expected?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2829] Confusing error message when Flin...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1993#discussion_r63589937
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java ---
@@ -405,8 +405,9 @@ public void onComplete(Throwable failure, Object success) throws Throwable {
}
else {
if (!(success.equals(Messages.getAcknowledge()))) {
- markFailed(new Exception("Failed to deploy the task to slot " + slot +
- ": Response was not of type Acknowledge"));
+ markFailed(new Exception("Failed to deploy the task to slot.Response was not of type Acknowledge.\n" +
+ "Please check sufficient memory is available for task threads for " + this + "\n" +
--- End diff --
I think the memory message is too specific. That may have been the point when the error was observed, but I assume that this is a rare case.
The message could simple be:
```java
new Exception("Failed to deploy the task to slot. Response was not of type 'Acknowledge', but was " + success + "\nSlot Details: " + slot);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2829] Confusing error message when Flin...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1993#issuecomment-219704691
This is Jira issue that I opened a qhile back and forgot about it :) The issue was not really that the Slot name was not well formatted etc, it's more thatn this type of error was very hard to debug as the exception message does not contain any info about the cause (out-of-memory error during thread creation)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2829] Confusing error message when Flin...
Posted by rekhajoshm <gi...@git.apache.org>.
Github user rekhajoshm commented on the pull request:
https://github.com/apache/flink/pull/1993#issuecomment-219833255
makes sense @StephanEwen done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---