You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dh...@apache.org on 2016/08/16 21:07:58 UTC

[1/2] incubator-beam git commit: ByteKeyRangeTracker: synchronize toString

Repository: incubator-beam
Updated Branches:
  refs/heads/master f1935d5d1 -> 9b4a464a3


ByteKeyRangeTracker: synchronize toString

It's the only unsynchronized function, and it could potentially produce bad data.

Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/b7c9a7bf
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/b7c9a7bf
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/b7c9a7bf

Branch: refs/heads/master
Commit: b7c9a7bf4711a404f206abfe9480312525fe4a46
Parents: f1935d5
Author: Daniel Halperin <dh...@users.noreply.github.com>
Authored: Tue Aug 16 13:11:16 2016 -0700
Committer: GitHub <no...@github.com>
Committed: Tue Aug 16 13:11:16 2016 -0700

----------------------------------------------------------------------
 .../java/org/apache/beam/sdk/io/range/ByteKeyRangeTracker.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/b7c9a7bf/sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/ByteKeyRangeTracker.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/ByteKeyRangeTracker.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/ByteKeyRangeTracker.java
index 7dd9a2c..24bf6e4 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/ByteKeyRangeTracker.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/range/ByteKeyRangeTracker.java
@@ -176,7 +176,7 @@ public final class ByteKeyRangeTracker implements RangeTracker<ByteKey> {
   }
 
   @Override
-  public String toString() {
+  public synchronized String toString() {
     return toStringHelper(ByteKeyRangeTracker.class)
         .add("range", range)
         .add("position", position)


[2/2] incubator-beam git commit: Closes #837

Posted by dh...@apache.org.
Closes #837


Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/9b4a464a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/9b4a464a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/9b4a464a

Branch: refs/heads/master
Commit: 9b4a464a3d1caee855d8eec05c426c47705dbc65
Parents: f1935d5 b7c9a7b
Author: Dan Halperin <dh...@google.com>
Authored: Tue Aug 16 14:07:46 2016 -0700
Committer: Dan Halperin <dh...@google.com>
Committed: Tue Aug 16 14:07:46 2016 -0700

----------------------------------------------------------------------
 .../java/org/apache/beam/sdk/io/range/ByteKeyRangeTracker.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------