[GitHub] [spark] sarutak commented on a change in pull request #25274: [SPARK-28537][SQL] DebugExec cannot debug broadcast or columnar related queries.

[GitBox <gi...@apache.org>]

sarutak commented on a change in pull request #25274: [SPARK-28537][SQL] DebugExec cannot debug broadcast or columnar related queries.
URL: https://github.com/apache/spark/pull/25274#discussion_r307991407
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala
 ##########
 @@ -48,4 +50,25 @@ class DebuggingSuite extends SparkFunSuite with SharedSQLContext {
     assert(res.forall{ case (subtree, code) =>
       subtree.contains("Range") && code.contains("Object[]")})
   }
+
+  test("debug() or broadcast and columnar") {
+    val rightDF = spark.range(10)
+    val leftDF = spark.range(10)
+    val joinedDF = leftDF.join(rightDF, leftDF("id") === rightDF("id"))
+    Try {
 
 Review comment:
   Thanks for the comment. I changed test-cases added to compare expected result to actual one. But I think it's good to handle exceptions for better error message when test-cases fail.
   To do so, it's easy for us to identify which test-case fails (line number appears on the top of error message).
   
   ```
   [info] - SPARK-28537: DebugExec cannot debug broadcast or columnar related queries *** FAILED *** (89 milliseconds)
   [info]   debug() for broadcast failed with exception (DebuggingSuite.scala:76)
   [info]   org.scalatest.exceptions.TestFailedException:
   [info]   at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:528)
   [info]   at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:527)
   [info]   at org.scalatest.FunSuite.newAssertionFailedException(FunSuite.scala:1560)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org