Re: [PR] [SPARK-48414][PYTHON] Fix breaking change in python's `fromJson` [spark]

["stefankandic (via GitHub)" <gi...@apache.org>]

stefankandic commented on code in PR #46737:
URL: https://github.com/apache/spark/pull/46737#discussion_r1661096813


##########
python/pyspark/sql/types.py:
##########
@@ -747,8 +747,8 @@ def jsonValue(self) -> Dict[str, Any]:
     def fromJson(
         cls,
         json: Dict[str, Any],
-        fieldPath: str,
-        collationsMap: Optional[Dict[str, str]],
+        fieldPath: str = "",
+        collationsMap: Optional[Dict[str, str]] = None,

Review Comment:
   Extensive testing was added in #46280, this change is just so that the API for the `fromJson` method doesn't change which we missed in the previous PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org