Re: cvs commit: httpd-2.0/modules/experimental util_ldap.c

[Jeff Trawick <tr...@gmail.com>]

On 13 Oct 2004 15:25:06 -0000, minfrin@apache.org <mi...@apache.org> wrote:
> minfrin     2004/10/13 08:25:06
> 
>   Modified:    .        Tag: APACHE_2_0_BRANCH CHANGES STATUS
>                modules/experimental Tag: APACHE_2_0_BRANCH util_ldap.c
>   Log:
>   mod_ldap: fix a bogus error message to tell the user which file
>   is causing a potential problem with the LDAP shared memory cache.

>   Index: util_ldap.c

>   @@ -1425,12 +1425,15 @@
> 
>        sts = apr_global_mutex_child_init(&st->util_ldap_cache_lock, st->lock_file, p);
>        if (sts != APR_SUCCESS) {
>   -        ap_log_error(APLOG_MARK, APLOG_CRIT, sts, s, "failed to init caching lock in child process");
>   +        ap_log_error(APLOG_MARK, APLOG_CRIT, sts, s,
>   +                     "Failed to initialise global mutex %s in child process %d.",
>   +                     st->lock_file, getpid());

another fix to make: format string for getpid() is "%" APR_PID_T_FMT
instead of "%d"...  there are common platforms that use long instead
of int for the pid

>            return;
>        }
>        else {
>            ap_log_error(APLOG_MARK, APLOG_DEBUG|APLOG_NOERRNO, 0, s,
>   -                     "INIT global mutex %s in child %d ", st->lock_file, getpid());
>   +                     "Initialisation of global mutex %s in child process %d successful.",
>   +                     st->lock_file, getpid());

ditto