You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@red-bean.com> on 2008/02/18 15:51:28 UTC
Re: svn log behaves strangely when characters cannot be represented in the local charset
Vincent Lefevre <vi...@vinc17.org> writes:
> Well, what you said earlier was ambiguous. But this isn't
> user-friendly. And you do *not* need a transliterating iconv to
> make it better. For instance,
>
> Test caractère non ISO-8859-1: ?\226?\134?\146
>
> would be better than:
>
> Test caract?\195?\168re non ISO-8859-1: ?\226?\134?\146
>
> i.e. transliterate only the characters that are not representable
> in the local charset.
No one here would ever argue against an unambiguous improvement, I
think :-). If you can make a patch that does that, that would be
great. (I'm assuming you're using "transliterate" above to mean
"convert to Subversion's ad hoc '?\NNN' representation".)
Branko is right that the current behavior is a deliberate choice,
though. We felt that log messages being printed to stdout were an
appropriate place for graceful degradation (as opposed to an error).
I'm not opposed to printing a warning to stderr as well, saying that
some log messages couldn't be fully converted; that way the user would
see the warning even if the log output were being redirected to a file.
If you have time to come up with a patch for that (independently of
the other change discussed above), that'd be great!
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn log behaves strangely when characters cannot be
represented in the local charset
Posted by Vincent Lefevre <vi...@vinc17.org>.
On 2008-02-18 10:51:28 -0500, Karl Fogel wrote:
> I'm not opposed to printing a warning to stderr as well, saying that
> some log messages couldn't be fully converted; that way the user would
> see the warning even if the log output were being redirected to a file.
> If you have time to come up with a patch for that (independently of
> the other change discussed above), that'd be great!
I've added that in my TODO, when I have the time... (amongst the
software I use, that's not the only problem I've found and for
which a patch is needed).
FYI, I've done a little test on my Debian machine:
find /usr/share/doc -name 'changelog*' -exec zgrep \
--color=always -H '\?\\[0-9]\+' \{\} \;
and guess what... I've found a changelog that was badly generated
(in vim-latexsuite... I've just reported the bug). If "svn log" had
signaled the problem in some form, perhaps the maintainer would
have noticed it.
--
Vincent Lefèvre <vi...@vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / Arenaire project (LIP, ENS-Lyon)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org