[GitHub] [avro] CamilAbraham commented on pull request #2439: AVRO-3802: [Csharp] Fix memory leak on deflate codec decompression

["CamilAbraham (via GitHub)" <gi...@apache.org>]

CamilAbraham commented on PR #2439:
URL: https://github.com/apache/avro/pull/2439#issuecomment-1680619890

   > @CamilAbraham @KalleOlaviNiemitalo After thinking more about the ownstream/leaveOpen issue. Adding that featurte requires to convert the BinaryEncoder and Decoder to become IDisposable. I dont think that should be in the scope of this ticket. My vote is not to add the Dispose feature to the Encoder and Decoder
   
   This was done since the beginning of the PR. The idea was that those 2 objects would dispose the Stream, reducing memory leakage (IMO making it part of the scope of the change). After @KalleOlaviNiemitalo pointed out that this would break some specific usages, the `ownStream` flag was introduced.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org