[GitHub] [storm] cjljohnson commented on a change in pull request #3131: STORM-3510: Track overflow count per taskId for resending backpressur…

[GitBox <gi...@apache.org>]

cjljohnson commented on a change in pull request #3131: STORM-3510: Track overflow count per taskId for resending backpressur…
URL: https://github.com/apache/storm/pull/3131#discussion_r329365482
 
 

 ##########
 File path: storm-client/src/jvm/org/apache/storm/daemon/worker/BackPressureTracker.java
 ##########
 @@ -39,6 +40,7 @@
 public class BackPressureTracker {
     static final Logger LOG = LoggerFactory.getLogger(BackPressureTracker.class);
     private final Map<Integer, BackpressureState> tasks;
+    private final Map<Integer, Integer> lastOverflowCount;
 
 Review comment:
   I agree that it would be cleaner to store it in the BackpressureState object, but can you clarify what you mean by transferLocalBatch will only need to look it up once?  The BackpressureState object isn't exposed beyond the BackPressureTracker class, so you are paying for two map lookups either way. Unless i'm misunderstanding?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services