[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5988: Improve messages on adding hosts errors

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #5988:
URL: https://github.com/apache/cloudstack/pull/5988#discussion_r805637092



##########
File path: server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
##########
@@ -372,13 +375,12 @@ private void setupAgentSecurity(final Connection sshConnection, final String age
             throw e;
         } catch (Exception e) {
             String msg = " can't setup agent, due to " + e.toString() + " - " + e.getMessage();
-            s_logger.warn(msg);
+            s_logger.warn(msg, e);

Review comment:
       ```suggestion
               s_logger.warn(msg);
               if (s_logger.isDebugEnabled()) {
                   s_logger.debug(msg, e);
               }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org