You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/10/30 20:25:13 UTC

Review Request: Fix for status update ack during driver abort

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7782/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Description
-------

Now the scheduler driver doesn't send a status update ack when the driver aborts.


This addresses bug MESOS-302.
    https://issues.apache.org/jira/browse/MESOS-302


Diffs
-----

  src/sched/sched.cpp 6f190e9f86d2ecdcfed8ec06831940606332e536 

Diff: https://reviews.apache.org/r/7782/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request: Fix for status update ack during driver abort

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7782/#review12926
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Oct. 30, 2012, 7:43 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7782/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2012, 7:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> Now the scheduler driver doesn't send a status update ack when the driver aborts.
> 
> 
> This addresses bug MESOS-302.
>     https://issues.apache.org/jira/browse/MESOS-302
> 
> 
> Diffs
> -----
> 
>   src/sched/sched.cpp 6f190e9f86d2ecdcfed8ec06831940606332e536 
>   src/tests/master_tests.cpp 7112c8c877eb4d852c36d65a7d44af74652239b3 
> 
> Diff: https://reviews.apache.org/r/7782/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request: Fix for status update ack during driver abort

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7782/
-----------------------------------------------------------

(Updated Oct. 30, 2012, 7:43 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

added a test


Description
-------

Now the scheduler driver doesn't send a status update ack when the driver aborts.


This addresses bug MESOS-302.
    https://issues.apache.org/jira/browse/MESOS-302


Diffs (updated)
-----

  src/sched/sched.cpp 6f190e9f86d2ecdcfed8ec06831940606332e536 
  src/tests/master_tests.cpp 7112c8c877eb4d852c36d65a7d44af74652239b3 

Diff: https://reviews.apache.org/r/7782/diff/


Testing
-------

make check


Thanks,

Vinod Kone