You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "klesh (via GitHub)" <gi...@apache.org> on 2023/04/06 08:51:31 UTC
[GitHub] [incubator-devlake] klesh opened a new issue, #4869: [Refactor][dora] Change Lead Time doesn't include Jenkins deployment and
klesh opened a new issue, #4869:
URL: https://github.com/apache/incubator-devlake/issues/4869
## What and why to refactor
1. #4825 indicates that deployment might be a `cicd_pipeline` or `cicd_task` from a user's perspective. Therefore, we need to broaden the scope of the "Deployment Regex" to include the `cicd_pipeline`.
2. Jenkins deployments are not included in Change Lead Time calculation. The `cicd_pipeline_commits` consist of the repositories and commit_shas being built or deployed by a `cicd_pipeline`, we currently rely on the `repo_id` field to distinguish different repos, for data sources like github/gitlabe, filling it is not a issue. However, for specialized tool like Jenkins, it may not be possible, reliable, or easy to provide such information. In such cases, the only dependable field would be the `repo_url`. All data source plugins must be updated to populate this field.
3. There are many ways to orchestrate a deployment, making it challenging to identify all possible scenarios. We have determined that a `deployment` (new table) is a `cicd_pipeline_commit` if the corresponding `cicd_pipeline` satisfies `type=deployment` or includes any `cicd_tasks` with `type=deployment`.
4. Currently, both `refdiff` and `dora` are identifying previous deployments separately and using different methods, which can lead to issues.
5. To determine the deployment of a pull request, we must identify the commits deployed by examining its preceding SUCCESSFUL deployment. To do this, we must group the deployments by `cicd_scope_id`, `env`, and `repo_url`, then sort them by their `started date`.
## Describe the solution you'd like
## Related issues
#4825
#4810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh closed issue #4869: [Refactor][dora] Change Lead Time doesn't include Jenkins deployment and other data correctness issues
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh closed issue #4869: [Refactor][dora] Change Lead Time doesn't include Jenkins deployment and other data correctness issues
URL: https://github.com/apache/incubator-devlake/issues/4869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] hezyin commented on issue #4869: [Refactor][dora] Change Lead Time doesn't include Jenkins deployment and other data correctness issues
Posted by "hezyin (via GitHub)" <gi...@apache.org>.
hezyin commented on issue #4869:
URL: https://github.com/apache/incubator-devlake/issues/4869#issuecomment-1500796687
Hi @klesh, I synced up the refactor plan with @keon94 and @CamilleTeruel today. They were on board with the plan and gave the following feedback:
1. It seems a bit unnatural for the refdiff plugin to generate deployments. That sounds more like the responsibility of the DORA plugin. Can you think of a solution that moves that logic out of the refdiff plugin?
2. Since we're going to change the schema of cicd_pipeline_commits table (replacing repo_id with repo_url), shall we coordinate the efforts to migrate all the existing CI/CD plugins? Keon and Camille are happy to take care of Azure DevOps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #4869: [Refactor][dora] Change Lead Time doesn't include Jenkins deployment and other data correctness issues
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #4869:
URL: https://github.com/apache/incubator-devlake/issues/4869#issuecomment-1501456409
@hezyin @keon94 @CamilleTeruel Flow chart has been updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on issue #4869: [Refactor][dora] Change Lead Time doesn't include Jenkins deployment and other data correctness issues
Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on issue #4869:
URL: https://github.com/apache/incubator-devlake/issues/4869#issuecomment-1499410112
@klesh Should this not be for the v0.18 milestone and cherry-picked back to v0.17, or are we delaying v0.17 until this gets done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #4869: [Refactor][dora] Change Lead Time doesn't include Jenkins deployment and other data correctness issues
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #4869:
URL: https://github.com/apache/incubator-devlake/issues/4869#issuecomment-1537649810
Finished
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #4869: [Refactor][dora] Change Lead Time doesn't include Jenkins deployment and other data correctness issues
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #4869:
URL: https://github.com/apache/incubator-devlake/issues/4869#issuecomment-1501044995
> Hi @klesh, I synced up the refactor plan with @keon94 and @CamilleTeruel today. They were on board with the plan and gave the following feedback:
>
> 1. It seems a bit unnatural for the refdiff plugin to generate deployments. That sounds more like the responsibility of the DORA plugin. Can you think of a solution that moves that logic out of the refdiff plugin?
>
> 2. Since we're going to change the schema of cicd_pipeline_commits table (replacing repo_id with repo_url), shall we coordinate the efforts to migrate all the existing CI/CD plugins? Keon and Camille are happy to take care of Azure DevOps.
1. good one, i will think about it
2. doc sent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh closed issue #4869: [Refactor][dora] Change Lead Time doesn't include Jenkins deployment and other data correctness issues
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh closed issue #4869: [Refactor][dora] Change Lead Time doesn't include Jenkins deployment and other data correctness issues
URL: https://github.com/apache/incubator-devlake/issues/4869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on issue #4869: [Refactor][dora] Change Lead Time doesn't include Jenkins deployment and other data correctness issues
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on issue #4869:
URL: https://github.com/apache/incubator-devlake/issues/4869#issuecomment-1499816012
@keon94 It ought to be fixed ASAP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] likyh closed issue #4869: [Refactor][dora] Change Lead Time doesn't include Jenkins deployment and other data correctness issues
Posted by "likyh (via GitHub)" <gi...@apache.org>.
likyh closed issue #4869: [Refactor][dora] Change Lead Time doesn't include Jenkins deployment and other data correctness issues
URL: https://github.com/apache/incubator-devlake/issues/4869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org