[GitHub] peng-yongsheng commented on issue #1970: fix 5.x too many open files

[GitBox <gi...@apache.org>]

peng-yongsheng commented on issue #1970: fix 5.x too many open files
URL: https://github.com/apache/incubator-skywalking/pull/1970#issuecomment-442707280
 
 
   From your changes seems ok, but I don't sure it was fixed this issue really. 
   Do you confirm the number of the file open handles by the collector's process? Recommended you refer to the following step for check.  
   1. Check the number of the file open handles after collector startup.
   1. Change the buffer config in application.yml. 
   `
   bufferOffsetMaxFileSize: 1 # Unit is MB
   bufferDataMaxFileSize: 1 # Unit is MB
   bufferFileCleanWhenRestart: true
   `
   1. Send more than 1k trace segments with different operator name to trigger the trace buffer reader and writer operate. And set a too long string into span's log, it could make the trace segment's length too long to let the buffer manager open more files.
   1. Check the number of the file open handles after segments send finish.
   1. Make sure the number of the file open handles is same as the number after collector startup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services