[GitHub] [incubator-brpc] lorinlee commented on a diff in pull request #1959: fix arena cleared early when parse redis message

[GitBox <gi...@apache.org>]

lorinlee commented on code in PR #1959:
URL: https://github.com/apache/incubator-brpc/pull/1959#discussion_r1001276914


##########
src/brpc/redis_command.h:
##########
@@ -53,6 +53,7 @@ class RedisCommandParser {
     // in `arena'.
     ParseError Consume(butil::IOBuf& buf, std::vector<butil::StringPiece>* args,
                        butil::Arena* arena);
+    int ParsedArgsSize();

Review Comment:
   这里返回类型用size_t吧



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org