You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@polaris.apache.org by "vigneshio (via GitHub)" <gi...@apache.org> on 2026/09/02 21:32:12 UTC

Re: [PR] fix(metrics): don't fail requests when persisting metrics fails [polaris]

vigneshio commented on code in PR #5395:
URL: https://github.com/apache/polaris/pull/5395#discussion_r3918870616


##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -794,16 +794,23 @@ public void reportMetrics(TableIdentifier identifier, ReportMetricsRequest reque
 
     MetricType metricType =

Review Comment:
   Good catch, thanks @jbonofre . You are right - moved it up so resolution is covered as well. If the leaf is missing or not `TABLE_LIKE`, we now log a `WARN` and drop the report, instead of hitting NPE or persisting a wrong table_id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org