You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Zoltan Martonka (Code Review)" <ge...@cloudera.org> on 2023/10/11 09:45:31 UTC
[kudu-CR] [build] bootsreap-dev-env python fix for ubuntu 22.04
Zoltan Martonka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20559
Change subject: [build] bootsreap-dev-env python fix for ubuntu 22.04
......................................................................
[build] bootsreap-dev-env python fix for ubuntu 22.04
There is no longer python package on ubuntu 22.04
We should install python3 and python-is-python3
Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c
---
M docker/bootstrap-dev-env.sh
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/20559/1
--
To view, visit http://gerrit.cloudera.org:8080/20559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c
Gerrit-Change-Number: 20559
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
[kudu-CR] [build] bootstrap-dev-env.sh fix for ubuntu 22.04+
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20559 )
Change subject: [build] bootstrap-dev-env.sh fix for ubuntu 22.04+
......................................................................
Patch Set 2: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/194/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/20559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c
Gerrit-Change-Number: 20559
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Jun 2024 15:37:13 +0000
Gerrit-HasComments: No
[kudu-CR] [build] bootsreap-dev-env python fix for ubuntu 22.04
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20559 )
Change subject: [build] bootsreap-dev-env python fix for ubuntu 22.04
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c
Gerrit-Change-Number: 20559
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 11 Oct 2023 10:53:31 +0000
Gerrit-HasComments: No
[kudu-CR] [build] bootsreap-dev-env python fix for ubuntu 22.04
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20559 )
Change subject: [build] bootsreap-dev-env python fix for ubuntu 22.04
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/20559/1/docker/bootstrap-dev-env.sh
File docker/bootstrap-dev-env.sh:
http://gerrit.cloudera.org:8080/#/c/20559/1/docker/bootstrap-dev-env.sh@a116
PS1, Line 116:
Why to remove updating the information on packages available in repo?
http://gerrit.cloudera.org:8080/#/c/20559/1/docker/bootstrap-dev-env.sh@116
PS1, Line 116: if [[ $(apt-cache search --names-only '^python$') ]]; then
: apt-get install -y --no-install-recommends python
I'm not sure this does what it's supposed to do.
For example, I have a machine where I got the following output, where python isn't among the packages available:
# apt-cache search --names-only '^python$'
python-is-python2 - symlinks /usr/bin/python to the DEPRECATED python2
# echo $?
0
With that, the updated script will try to install the 'python', even if it's not available.
BTW, how is it supposed to work on, say, Ubuntu20.04? Have you verified it works as expected there?
--
To view, visit http://gerrit.cloudera.org:8080/20559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c
Gerrit-Change-Number: 20559
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 11 Oct 2023 18:49:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] bootstrap-dev-env.sh fix for ubuntu 22.04+
Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20559
to look at the new patch set (#2).
Change subject: [build] bootstrap-dev-env.sh fix for ubuntu 22.04+
......................................................................
[build] bootstrap-dev-env.sh fix for ubuntu 22.04+
On Ubuntu 22.04 python package is renamed to python2
On 23.10 and 24.04 python2 is no longer available.
We should just use python3 on newer platforms.
Tested on: 18.04, 20.04. 22.04, 23.10, 24.04
Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c
---
M docker/bootstrap-dev-env.sh
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/20559/2
--
To view, visit http://gerrit.cloudera.org:8080/20559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c
Gerrit-Change-Number: 20559
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [build] bootstrap-dev-env.sh fix for ubuntu 22.04+
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20559 )
Change subject: [build] bootstrap-dev-env.sh fix for ubuntu 22.04+
......................................................................
[build] bootstrap-dev-env.sh fix for ubuntu 22.04+
On Ubuntu 22.04 python package is renamed to python2
On 23.10 and 24.04 python2 is no longer available.
We should just use python3 on newer platforms.
Tested on: 18.04, 20.04. 22.04, 23.10, 24.04
Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c
Reviewed-on: http://gerrit.cloudera.org:8080/20559
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M docker/bootstrap-dev-env.sh
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c
Gerrit-Change-Number: 20559
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward (763)
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] [build] bootstrap-dev-env.sh fix for ubuntu 22.04+
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20559 )
Change subject: [build] bootstrap-dev-env.sh fix for ubuntu 22.04+
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/194/
--
To view, visit http://gerrit.cloudera.org:8080/20559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c
Gerrit-Change-Number: 20559
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Jun 2024 15:36:51 +0000
Gerrit-HasComments: No
[kudu-CR] [build] bootstrap-dev-env.sh fix for ubuntu 22.04+
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward (763) has posted comments on this change. ( http://gerrit.cloudera.org:8080/20559 )
Change subject: [build] bootstrap-dev-env.sh fix for ubuntu 22.04+
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20559/1/docker/bootstrap-dev-env.sh
File docker/bootstrap-dev-env.sh:
http://gerrit.cloudera.org:8080/#/c/20559/1/docker/bootstrap-dev-env.sh@116
PS1, Line 116: apt-get update -y
:
> I'm not sure this does what it's supposed to do.
On ubuntu 20.04 if you run "apt install python" it will install python2. apt-cache search says there is no such package :D. So the script works. Not exatly how it should, but it does.
There is this line during install:
Note, selecting 'python-is-python2' instead of 'python'
I updated with a different aproach. This should work on all current non-deprecated versions (+ 18.04).
--
To view, visit http://gerrit.cloudera.org:8080/20559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c
Gerrit-Change-Number: 20559
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward (763)
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Jun 2024 15:54:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] bootstrap-dev-env.sh fix for ubuntu 22.04+
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20559 )
Change subject: [build] bootstrap-dev-env.sh fix for ubuntu 22.04+
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20559/1/docker/bootstrap-dev-env.sh
File docker/bootstrap-dev-env.sh:
http://gerrit.cloudera.org:8080/#/c/20559/1/docker/bootstrap-dev-env.sh@116
PS1, Line 116: apt-get update -y
:
> On ubuntu 20.04 if you run "apt install python" it will install python2. ap
Thank you for the updates: now this looks better.
--
To view, visit http://gerrit.cloudera.org:8080/20559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c
Gerrit-Change-Number: 20559
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Anonymous Coward (763)
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Jun 2024 21:15:06 +0000
Gerrit-HasComments: Yes