You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "john-bodley (via GitHub)" <gi...@apache.org> on 2023/04/04 20:10:27 UTC

[GitHub] [superset] john-bodley opened a new pull request, #23579: fix(revert): "fix: cache warmup solution non legacy charts. (#23012)"

john-bodley opened a new pull request, #23579:
URL: https://github.com/apache/superset/pull/23579

   
   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   This reverts http://github.com/apache/superset/pull/23012 which per https://github.com/apache/superset/pull/23012#issuecomment-1496518374 introduced two known regressions. Granted we could try to roll forward with a formulation which works for both legacy and non-legacy charts, but in the interim I think it's prudent we ensure we don't regress whilst acknowledging the fact that cache warmup for non-legacy charts is still problematic.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   
   CI.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #23579: fix(revert): "fix: cache warmup solution non legacy charts. (#23012)"

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23579:
URL: https://github.com/apache/superset/pull/23579#issuecomment-1496553472

   ## [Codecov](https://codecov.io/gh/apache/superset/pull/23579?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#23579](https://codecov.io/gh/apache/superset/pull/23579?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (539367a) into [master](https://codecov.io/gh/apache/superset/commit/9d2f43d312c37c8c6827c2f94de6b5e3e1431014?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d2f43d) will **decrease** coverage by `11.34%`.
   > The diff coverage is `10.00%`.
   
   > :exclamation: Current head 539367a differs from pull request most recent head 9fd6c89. Consider uploading reports for the commit 9fd6c89 to get more accurate results
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #23579       +/-   ##
   ===========================================
   - Coverage   67.71%   56.37%   -11.34%     
   ===========================================
     Files        1916     1916               
     Lines       74014    74007        -7     
     Branches     8039     8039               
   ===========================================
   - Hits        50122    41725     -8397     
   - Misses      21843    30233     +8390     
     Partials     2049     2049               
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `?` | |
   | mysql | `?` | |
   | postgres | `?` | |
   | presto | `52.68% <10.00%> (+<0.01%)` | :arrow_up: |
   | python | `58.97% <10.00%> (-23.45%)` | :arrow_down: |
   | sqlite | `?` | |
   | unit | `52.64% <10.00%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/23579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/23579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `36.32% <0.00%> (-38.35%)` | :arrow_down: |
   | [superset/charts/commands/export.py](https://codecov.io/gh/apache/superset/pull/23579?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `52.94% <100.00%> (-41.18%)` | :arrow_down: |
   
   ... and [300 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23579/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] john-bodley merged pull request #23579: fix(revert): "fix: cache warmup solution non legacy charts. (#23012)"

Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley merged PR #23579:
URL: https://github.com/apache/superset/pull/23579


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] villebro commented on pull request #23579: fix(revert): "fix: cache warmup solution non legacy charts. (#23012)"

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #23579:
URL: https://github.com/apache/superset/pull/23579#issuecomment-1498004345

   Ok thanks for the heads up @john-bodley . I'll make sure to incorporate the work from all prior PRs in my fix 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] john-bodley commented on pull request #23579: fix(revert): "fix: cache warmup solution non legacy charts. (#23012)"

Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #23579:
URL: https://github.com/apache/superset/pull/23579#issuecomment-1497986308

   Thanks @villebro. Note https://github.com/apache/superset/pull/23569 was a fix for https://github.com/apache/superset/pull/23012 which now can't be applied because the execution path in the test has changed after the revert, so if/when you work on a fix it would be good to incorporate said change into it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org