You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ml...@apache.org on 2017/03/01 18:55:15 UTC
spark git commit: [SPARK-19787][ML] Changing the default parameter of
regParam.
Repository: spark
Updated Branches:
refs/heads/master 8aa560b75 -> 417140e44
[SPARK-19787][ML] Changing the default parameter of regParam.
## What changes were proposed in this pull request?
In the ALS method the default values of regParam do not match within the same file (lines [224](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L224) and [714](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala#L714)). In one place we set it to 1.0 and in the other to 0.1.
I changed the one of train() method to 0.1 and now it matches the default value which is visible to Spark users. The method is marked with DeveloperApi so it should not affect the users. Whenever we use the particular method we provide all parameters, so the default does not matter. Only exception is the unit-tests on ALSSuite but the change does not break them.
Note: This PR should get the award of the laziest commit in Spark history. Originally I wanted to correct this on another PR but MLnick [suggested](https://github.com/apache/spark/pull/17059#issuecomment-283333572) to create a separate PR & ticket. If you think this change is too insignificant/minor, you are probably right, so feel free to reject and close this. :)
## How was this patch tested?
Unit-tests
Author: Vasilis Vryniotis <vv...@hotels.com>
Closes #17121 from datumbox/als_regparam.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/417140e4
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/417140e4
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/417140e4
Branch: refs/heads/master
Commit: 417140e441505f20eb5bd4943ce216c3ec6adc10
Parents: 8aa560b
Author: Vasilis Vryniotis <vv...@hotels.com>
Authored: Wed Mar 1 20:55:17 2017 +0200
Committer: Nick Pentreath <ni...@za.ibm.com>
Committed: Wed Mar 1 20:55:17 2017 +0200
----------------------------------------------------------------------
mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/417140e4/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
----------------------------------------------------------------------
diff --git a/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala b/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
index af00762..04273a4 100644
--- a/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
+++ b/mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
@@ -711,7 +711,7 @@ object ALS extends DefaultParamsReadable[ALS] with Logging {
numUserBlocks: Int = 10,
numItemBlocks: Int = 10,
maxIter: Int = 10,
- regParam: Double = 1.0,
+ regParam: Double = 0.1,
implicitPrefs: Boolean = false,
alpha: Double = 1.0,
nonnegative: Boolean = false,
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org