You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by gu...@apache.org on 2013/08/09 08:52:29 UTC
svn commit: r1512165 - in /hive/trunk/ql/src:
java/org/apache/hadoop/hive/ql/exec/NumericOpMethodResolver.java
test/queries/clientnegative/invalid_arithmetic_type.q
test/results/clientnegative/invalid_arithmetic_type.q.out
Author: gunther
Date: Fri Aug 9 06:52:29 2013
New Revision: 1512165
URL: http://svn.apache.org/r1512165
Log:
HIVE-3191: timestamp - timestamp causes null pointer exception (Jason Dere via Gunther Hagleitner)
Added:
hive/trunk/ql/src/test/queries/clientnegative/invalid_arithmetic_type.q
hive/trunk/ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out
Modified:
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/NumericOpMethodResolver.java
Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/NumericOpMethodResolver.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/NumericOpMethodResolver.java?rev=1512165&r1=1512164&r2=1512165&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/NumericOpMethodResolver.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/NumericOpMethodResolver.java Fri Aug 9 06:52:29 2013
@@ -138,6 +138,11 @@ public class NumericOpMethodResolver imp
}
}
}
+
+ if (udfMethod == null) {
+ throw new NoMatchingMethodException(udfClass, argTypeInfos, null);
+ }
+
return udfMethod;
}
}
Added: hive/trunk/ql/src/test/queries/clientnegative/invalid_arithmetic_type.q
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/test/queries/clientnegative/invalid_arithmetic_type.q?rev=1512165&view=auto
==============================================================================
--- hive/trunk/ql/src/test/queries/clientnegative/invalid_arithmetic_type.q (added)
+++ hive/trunk/ql/src/test/queries/clientnegative/invalid_arithmetic_type.q Fri Aug 9 06:52:29 2013
@@ -0,0 +1,3 @@
+
+select timestamp('2001-01-01 00:00:01') - timestamp('2000-01-01 00:00:01') from src;
+
Added: hive/trunk/ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out?rev=1512165&view=auto
==============================================================================
--- hive/trunk/ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out (added)
+++ hive/trunk/ql/src/test/results/clientnegative/invalid_arithmetic_type.q.out Fri Aug 9 06:52:29 2013
@@ -0,0 +1 @@
+FAILED: SemanticException Line 0:-1 Wrong arguments ''2000-01-01 00:00:01'': No matching method for class org.apache.hadoop.hive.ql.udf.UDFOPMinus with (timestamp, timestamp)