You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/07/06 00:53:22 UTC
[kudu-CR] java: remove log message causing ITClientStress to fail
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7357
to review the following change.
Change subject: java: remove log message causing ITClientStress to fail
......................................................................
java: remove log message causing ITClientStress to fail
ITClientStress checks that the logs don't contain the word
'SSLException', but a recent change added a debug-level message
indicating it. Since the debug message isn't actionable, this commit
just removes it.
Change-Id: I39c485012254c3bebc57ebc07c620f76e852d9fb
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/7357/1
--
To view, visit http://gerrit.cloudera.org:8080/7357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39c485012254c3bebc57ebc07c620f76e852d9fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] java: remove log message causing ITClientStress to fail
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: java: remove log message causing ITClientStress to fail
......................................................................
java: remove log message causing ITClientStress to fail
ITClientStress checks that the logs don't contain the word
'SSLException', but a recent change added a debug-level message
indicating it. Since the debug message isn't actionable, this commit
just removes it.
Change-Id: I39c485012254c3bebc57ebc07c620f76e852d9fb
Reviewed-on: http://gerrit.cloudera.org:8080/7357
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39c485012254c3bebc57ebc07c620f76e852d9fb
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] java: remove log message causing ITClientStress to fail
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: java: remove log message causing ITClientStress to fail
......................................................................
Patch Set 1:
> > hm, for me running it through Eclipse it failed pretty regularly.
> >
> > I wonder if there is some log-level difference and maybe when not
> > running through eclipse it doesn't happen?
>
> I ran it using IntelliJIdea IDE. It does not fail if running
> separately and I don't recall it failing if running among the whole
> bunch of the Java tests.
>
> However, I noticed that some tests fail time to time when running
> then in the bunch (like TestTimeouts), but those are not failing if
> runing then multiple times on their own.
>
> I didn't look at that closely, partly because I saw the same result
> prior to my changes and I could understand why such inconsistent
> behavior would be possible just after looking a couple of minutes
> at those tests.
... and I could not understand why such inconsistent behavior ...
--
To view, visit http://gerrit.cloudera.org:8080/7357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c485012254c3bebc57ebc07c620f76e852d9fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] java: remove log message causing ITClientStress to fail
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: java: remove log message causing ITClientStress to fail
......................................................................
Patch Set 1:
For some reason I could not see the ITClientStress test failing with that change. Is that happens once in 100 runs or so?
--
To view, visit http://gerrit.cloudera.org:8080/7357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c485012254c3bebc57ebc07c620f76e852d9fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] java: remove log message causing ITClientStress to fail
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: java: remove log message causing ITClientStress to fail
......................................................................
Patch Set 1:
hm, for me running it through Eclipse it failed pretty regularly.
I wonder if there is some log-level difference and maybe when not running through eclipse it doesn't happen?
--
To view, visit http://gerrit.cloudera.org:8080/7357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c485012254c3bebc57ebc07c620f76e852d9fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] java: remove log message causing ITClientStress to fail
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: java: remove log message causing ITClientStress to fail
......................................................................
Patch Set 1:
> For some reason I could not see the ITClientStress test failing
> with that change. Is that happens once in 100 runs or so?
I meant 'without this change', i.e. the code as in 58248841f213a64683ee217f025f0a38a8450f74 worked for me with no failures in this test.
--
To view, visit http://gerrit.cloudera.org:8080/7357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c485012254c3bebc57ebc07c620f76e852d9fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] java: remove log message causing ITClientStress to fail
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: java: remove log message causing ITClientStress to fail
......................................................................
Patch Set 1:
> hm, for me running it through Eclipse it failed pretty regularly.
>
> I wonder if there is some log-level difference and maybe when not
> running through eclipse it doesn't happen?
I ran it using IntelliJIdea IDE. It does not fail if running separately and I don't recall it failing if running among the whole bunch of the Java tests.
However, I noticed that some tests fail time to time when running then in the bunch (like TestTimeouts), but those are not failing if runing then multiple times on their own.
I didn't look at that closely, partly because I saw the same result prior to my changes and I could understand why such inconsistent behavior would be possible just after looking a couple of minutes at those tests.
--
To view, visit http://gerrit.cloudera.org:8080/7357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c485012254c3bebc57ebc07c620f76e852d9fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] java: remove log message causing ITClientStress to fail
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: java: remove log message causing ITClientStress to fail
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39c485012254c3bebc57ebc07c620f76e852d9fb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No