You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/21 11:11:31 UTC
[GitHub] [airflow] potiuk opened a new pull request #13810: Clarifies differences between extras and provider packages
potiuk opened a new pull request #13810:
URL: https://github.com/apache/airflow/pull/13810
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#discussion_r561839120
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -15,22 +15,21 @@
specific language governing permissions and limitations
under the License.
-Extra Packages Reference
-''''''''''''''''''''''''
+Reference for package extras
+''''''''''''''''''''''''''''
-Here's the list of the :ref:`subpackages <installation:extra_packages>` and what they enable.
+Here's the list of all the :ref:`extra dependencies <installation:airflow_extra_dependencies>`.
-The entries with ``*`` in the ``Providers`` column indicate that one or more provider will be installed
-automatically when those extras are installed. In those cases, there is a dependency between corresponding
-provider packages and ``apache-airflow`` package (the provider package depends on ``apache-airflow>=2.0.0``).
+Most of the the extras result in installing additional provider packages.
+
+The entries with ``*`` in the ``Providers`` column indicate that one or more provider packages will be
+installed automatically when those extras are used.
For ``provider`` extras - they usually install single ``provider`` package, but for extras that are groups
of other extras (for example ``all`` or ``devel_all`` or ``all_dbs``) there might be more than one provider
installed together with the extra.
Review comment:
I like the name 'bundle extras'. I reviewed and refactored the page to include that!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] noelmcloughlin commented on a change in pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
noelmcloughlin commented on a change in pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#discussion_r561802673
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -15,22 +15,21 @@
specific language governing permissions and limitations
under the License.
-Extra Packages Reference
-''''''''''''''''''''''''
+Reference for package extras
Review comment:
Or simply "Package Extras Explained" if audience includes end-users. "Reference" is correct but slightly technical term.
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -15,22 +15,21 @@
specific language governing permissions and limitations
under the License.
-Extra Packages Reference
-''''''''''''''''''''''''
+Reference for package extras
+''''''''''''''''''''''''''''
-Here's the list of the :ref:`subpackages <installation:extra_packages>` and what they enable.
+Here's the list of all the :ref:`extra dependencies <installation:airflow_extra_dependencies>`.
-The entries with ``*`` in the ``Providers`` column indicate that one or more provider will be installed
-automatically when those extras are installed. In those cases, there is a dependency between corresponding
-provider packages and ``apache-airflow`` package (the provider package depends on ``apache-airflow>=2.0.0``).
+Most of the the extras result in installing additional provider packages.
+
+The entries with ``*`` in the ``Providers`` column indicate that one or more provider packages will be
+installed automatically when those extras are used.
For ``provider`` extras - they usually install single ``provider`` package, but for extras that are groups
of other extras (for example ``all`` or ``devel_all`` or ``all_dbs``) there might be more than one provider
installed together with the extra.
Review comment:
Could be simplified as (say)
'For ``provider`` extras - they usually install single ``provider`` package. For ``bundle`` extras - they usually install a group of extras (for example ``all`` or ``devel_all`` or ``all_dbs``), and include two or more ``provider`` extras.
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -15,22 +15,21 @@
specific language governing permissions and limitations
under the License.
-Extra Packages Reference
-''''''''''''''''''''''''
+Reference for package extras
+''''''''''''''''''''''''''''
-Here's the list of the :ref:`subpackages <installation:extra_packages>` and what they enable.
+Here's the list of all the :ref:`extra dependencies <installation:airflow_extra_dependencies>`.
-The entries with ``*`` in the ``Providers`` column indicate that one or more provider will be installed
-automatically when those extras are installed. In those cases, there is a dependency between corresponding
-provider packages and ``apache-airflow`` package (the provider package depends on ``apache-airflow>=2.0.0``).
+Most of the the extras result in installing additional provider packages.
+
+The entries with ``*`` in the ``Providers`` column indicate that one or more provider packages will be
+installed automatically when those extras are used.
For ``provider`` extras - they usually install single ``provider`` package, but for extras that are groups
of other extras (for example ``all`` or ``devel_all`` or ``all_dbs``) there might be more than one provider
installed together with the extra.
The entries with ``*`` in the ``Preinstalled`` column indicate that those extras (with providers) are always
-pre-installed when Airflow is installed. In this case dependencies are reverted - the ``apache-airflow``
-package depends on the corresponding providers packages. This is in order to avoid circular dependency that
-can be reported by some tools (even if it is harmless).
+pre-installed when Airflow is installed.
Review comment:
Should ``Preinstalled`` column be added to the other tables?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13810:
URL: https://github.com/apache/airflow/pull/13810
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#issuecomment-764714610
> LGTM. thanks!! @potiuk
Thanks for cooperation! If you see any more corrections needed to the docs or elsewhere - feel free to create PRs on your own - happy to review and merge it :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#issuecomment-767104707
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#discussion_r561827988
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -15,22 +15,21 @@
specific language governing permissions and limitations
under the License.
-Extra Packages Reference
-''''''''''''''''''''''''
+Reference for package extras
+''''''''''''''''''''''''''''
-Here's the list of the :ref:`subpackages <installation:extra_packages>` and what they enable.
+Here's the list of all the :ref:`extra dependencies <installation:airflow_extra_dependencies>`.
-The entries with ``*`` in the ``Providers`` column indicate that one or more provider will be installed
-automatically when those extras are installed. In those cases, there is a dependency between corresponding
-provider packages and ``apache-airflow`` package (the provider package depends on ``apache-airflow>=2.0.0``).
+Most of the the extras result in installing additional provider packages.
+
+The entries with ``*`` in the ``Providers`` column indicate that one or more provider packages will be
+installed automatically when those extras are used.
For ``provider`` extras - they usually install single ``provider`` package, but for extras that are groups
of other extras (for example ``all`` or ``devel_all`` or ``all_dbs``) there might be more than one provider
installed together with the extra.
The entries with ``*`` in the ``Preinstalled`` column indicate that those extras (with providers) are always
-pre-installed when Airflow is installed. In this case dependencies are reverted - the ``apache-airflow``
-package depends on the corresponding providers packages. This is in order to avoid circular dependency that
-can be reported by some tools (even if it is harmless).
+pre-installed when Airflow is installed.
Review comment:
No neeed. Only the 4 `provider` packages are pre-installed. All others have to be explicitly added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#discussion_r561827988
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -15,22 +15,21 @@
specific language governing permissions and limitations
under the License.
-Extra Packages Reference
-''''''''''''''''''''''''
+Reference for package extras
+''''''''''''''''''''''''''''
-Here's the list of the :ref:`subpackages <installation:extra_packages>` and what they enable.
+Here's the list of all the :ref:`extra dependencies <installation:airflow_extra_dependencies>`.
-The entries with ``*`` in the ``Providers`` column indicate that one or more provider will be installed
-automatically when those extras are installed. In those cases, there is a dependency between corresponding
-provider packages and ``apache-airflow`` package (the provider package depends on ``apache-airflow>=2.0.0``).
+Most of the the extras result in installing additional provider packages.
+
+The entries with ``*`` in the ``Providers`` column indicate that one or more provider packages will be
+installed automatically when those extras are used.
For ``provider`` extras - they usually install single ``provider`` package, but for extras that are groups
of other extras (for example ``all`` or ``devel_all`` or ``all_dbs``) there might be more than one provider
installed together with the extra.
The entries with ``*`` in the ``Preinstalled`` column indicate that those extras (with providers) are always
-pre-installed when Airflow is installed. In this case dependencies are reverted - the ``apache-airflow``
-package depends on the corresponding providers packages. This is in order to avoid circular dependency that
-can be reported by some tools (even if it is harmless).
+pre-installed when Airflow is installed.
Review comment:
No neeed. Only the 4 `provider` packages are pre-installed. All others have to be explicitly added
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -15,22 +15,21 @@
specific language governing permissions and limitations
under the License.
-Extra Packages Reference
-''''''''''''''''''''''''
+Reference for package extras
Review comment:
We use that term in other parts (for example https://github.com/apache/airflow/blob/master/docs/apache-airflow/operators-and-hooks-ref.rst) so I prefer to keep it consistent :)
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -15,22 +15,21 @@
specific language governing permissions and limitations
under the License.
-Extra Packages Reference
-''''''''''''''''''''''''
+Reference for package extras
+''''''''''''''''''''''''''''
-Here's the list of the :ref:`subpackages <installation:extra_packages>` and what they enable.
+Here's the list of all the :ref:`extra dependencies <installation:airflow_extra_dependencies>`.
-The entries with ``*`` in the ``Providers`` column indicate that one or more provider will be installed
-automatically when those extras are installed. In those cases, there is a dependency between corresponding
-provider packages and ``apache-airflow`` package (the provider package depends on ``apache-airflow>=2.0.0``).
+Most of the the extras result in installing additional provider packages.
+
+The entries with ``*`` in the ``Providers`` column indicate that one or more provider packages will be
+installed automatically when those extras are used.
For ``provider`` extras - they usually install single ``provider`` package, but for extras that are groups
of other extras (for example ``all`` or ``devel_all`` or ``all_dbs``) there might be more than one provider
installed together with the extra.
Review comment:
I like the name 'bundle extras'. I reviewed and refactored the page to include that!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] leahecole commented on a change in pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
leahecole commented on a change in pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#discussion_r562951209
##########
File path: docs/apache-airflow/upgrading-to-2.rst
##########
@@ -287,7 +287,7 @@ When DAGs are initialized with the ``access_control`` variable set, any usage of
Breaking change
Previously we were using two versions of UI, which were hard to maintain as we need to implement/update the same feature
- in both versions. With this release we've removed the older UI in favor of Flask App Builder RBAC UI. No need to set the
+ in both versions. With this release we have removed the older UI in favor of Flask App Builder RBAC UI. No need to set the
Review comment:
Some grammar nits, recommended rewrite here:
Previously we were using two versions of the UI. This was difficult to maintain, because it meant we had to implement/update features in two places. With this release, we have removed the older UI in favor of the Flask App Builder RBAC UI, reducing a huge maintenance burden. There is no longer a need to set the RBAC UI explicitly in the configuration, as it is the only default UI.
##########
File path: docs/apache-airflow/upgrading-to-2.rst
##########
@@ -287,7 +287,7 @@ When DAGs are initialized with the ``access_control`` variable set, any usage of
Breaking change
Previously we were using two versions of UI, which were hard to maintain as we need to implement/update the same feature
- in both versions. With this release we've removed the older UI in favor of Flask App Builder RBAC UI. No need to set the
+ in both versions. With this release we have removed the older UI in favor of Flask App Builder RBAC UI. No need to set the
RBAC UI explicitly in the configuration now as this is the only default UI. We did it to avoid
the huge maintenance burden of two independent user interfaces
Review comment:
Question - is there any action that users need to take? Or is this more of an FYI doc? If there is any action, let folks know the steps here.
##########
File path: docs/apache-airflow/installation.rst
##########
@@ -70,27 +70,24 @@ Installing via ``Poetry`` or ``pip-tools`` is not currently supported. If you wi
using those tools you should use the :ref:`constraint files <installation:constraints>` and convert them to appropriate
Review comment:
It won't let me comment on line 25 cuz there's no change but I wanted to let you know there's an I in PyPI that should be capitalized :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#discussion_r563163572
##########
File path: docs/apache-airflow/upgrading-to-2.rst
##########
@@ -287,7 +287,7 @@ When DAGs are initialized with the ``access_control`` variable set, any usage of
Breaking change
Previously we were using two versions of UI, which were hard to maintain as we need to implement/update the same feature
- in both versions. With this release we've removed the older UI in favor of Flask App Builder RBAC UI. No need to set the
+ in both versions. With this release we have removed the older UI in favor of Flask App Builder RBAC UI. No need to set the
RBAC UI explicitly in the configuration now as this is the only default UI. We did it to avoid
the huge maintenance burden of two independent user interfaces
Review comment:
God point - I added it. It's a bit different chang (the 've') change was mostly because spellcheck complained. I will make it separate change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13810:
URL: https://github.com/apache/airflow/pull/13810
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#discussion_r561828738
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -15,22 +15,21 @@
specific language governing permissions and limitations
under the License.
-Extra Packages Reference
-''''''''''''''''''''''''
+Reference for package extras
Review comment:
We use that term in other parts (for example https://github.com/apache/airflow/blob/master/docs/apache-airflow/operators-and-hooks-ref.rst) so I prefer to keep it consistent :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#discussion_r563162965
##########
File path: docs/apache-airflow/upgrading-to-2.rst
##########
@@ -287,7 +287,7 @@ When DAGs are initialized with the ``access_control`` variable set, any usage of
Breaking change
Previously we were using two versions of UI, which were hard to maintain as we need to implement/update the same feature
- in both versions. With this release we've removed the older UI in favor of Flask App Builder RBAC UI. No need to set the
+ in both versions. With this release we have removed the older UI in favor of Flask App Builder RBAC UI. No need to set the
Review comment:
I like it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] noelmcloughlin commented on a change in pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
noelmcloughlin commented on a change in pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#discussion_r561810514
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -15,22 +15,21 @@
specific language governing permissions and limitations
under the License.
-Extra Packages Reference
-''''''''''''''''''''''''
+Reference for package extras
+''''''''''''''''''''''''''''
-Here's the list of the :ref:`subpackages <installation:extra_packages>` and what they enable.
+Here's the list of all the :ref:`extra dependencies <installation:airflow_extra_dependencies>`.
-The entries with ``*`` in the ``Providers`` column indicate that one or more provider will be installed
-automatically when those extras are installed. In those cases, there is a dependency between corresponding
-provider packages and ``apache-airflow`` package (the provider package depends on ``apache-airflow>=2.0.0``).
+Most of the the extras result in installing additional provider packages.
+
+The entries with ``*`` in the ``Providers`` column indicate that one or more provider packages will be
+installed automatically when those extras are used.
For ``provider`` extras - they usually install single ``provider`` package, but for extras that are groups
of other extras (for example ``all`` or ``devel_all`` or ``all_dbs``) there might be more than one provider
installed together with the extra.
Review comment:
Could be simplified as (say)
'For ``provider`` extras - they usually install single ``provider`` package. For ``bundle`` extras - they usually install a group of extras (for example ``all`` or ``devel_all`` or ``all_dbs``), and include two or more ``provider`` extras.
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -15,22 +15,21 @@
specific language governing permissions and limitations
under the License.
-Extra Packages Reference
-''''''''''''''''''''''''
+Reference for package extras
+''''''''''''''''''''''''''''
-Here's the list of the :ref:`subpackages <installation:extra_packages>` and what they enable.
+Here's the list of all the :ref:`extra dependencies <installation:airflow_extra_dependencies>`.
-The entries with ``*`` in the ``Providers`` column indicate that one or more provider will be installed
-automatically when those extras are installed. In those cases, there is a dependency between corresponding
-provider packages and ``apache-airflow`` package (the provider package depends on ``apache-airflow>=2.0.0``).
+Most of the the extras result in installing additional provider packages.
+
+The entries with ``*`` in the ``Providers`` column indicate that one or more provider packages will be
+installed automatically when those extras are used.
For ``provider`` extras - they usually install single ``provider`` package, but for extras that are groups
of other extras (for example ``all`` or ``devel_all`` or ``all_dbs``) there might be more than one provider
installed together with the extra.
The entries with ``*`` in the ``Preinstalled`` column indicate that those extras (with providers) are always
-pre-installed when Airflow is installed. In this case dependencies are reverted - the ``apache-airflow``
-package depends on the corresponding providers packages. This is in order to avoid circular dependency that
-can be reported by some tools (even if it is harmless).
+pre-installed when Airflow is installed.
Review comment:
Should ``Preinstalled`` column be added to the other tables?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] noelmcloughlin commented on a change in pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
noelmcloughlin commented on a change in pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#discussion_r561802673
##########
File path: docs/apache-airflow/extra-packages-ref.rst
##########
@@ -15,22 +15,21 @@
specific language governing permissions and limitations
under the License.
-Extra Packages Reference
-''''''''''''''''''''''''
+Reference for package extras
Review comment:
Or simply "Package Extras Explained" if audience includes end-users. "Reference" is correct but slightly technical term.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#issuecomment-764714610
> LGTM. thanks!! @potiuk
Thanks for cooperation! If you see any more corrections needed to the docs or elsewhere - feel free to create PRs on your own - happy to review and merge it :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#issuecomment-767104707
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13810: Clarifies differences between extras and provider packages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13810:
URL: https://github.com/apache/airflow/pull/13810#issuecomment-766095307
[The Workflow run](https://github.com/apache/airflow/actions/runs/505925348) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org