[GitHub] [incubator-opendal] suyanhanx commented on a diff in pull request #1772: feat(bindings/nodejs): Support presign

["suyanhanx (via GitHub)" <gi...@apache.org>]

suyanhanx commented on code in PR #1772:
URL: https://github.com/apache/incubator-opendal/pull/1772#discussion_r1148504451


##########
bindings/nodejs/index.d.ts:
##########
@@ -101,3 +119,15 @@ export class Lister {
 export class BlockingLister {
   next(): Entry | null
 }
+export class PresignedRequest {
+  /** Returns the HTTP method of this request. */
+  get method(): string
+  /** Returns the URI of this request. */
+  get uri(): string
+  /**
+   * Returns the headers of this request.
+   *
+   * The key of the map is the header name, and the value is the header value AS bytes.
+   */
+  headers(): Record<string, Array<number>>

Review Comment:
   I'm not completely sure yet. This is still a draft.
   
   According to the HTTP spec, the values should all be strings. I'm considering changing them to string.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org