You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "shuwenwei (via GitHub)" <gi...@apache.org> on 2023/09/06 06:41:42 UTC
[GitHub] [iotdb] shuwenwei opened a new pull request, #11054: [To rel/1.1] Release chunk data buffer after copy page data from it in aligned series FastCompaction
shuwenwei opened a new pull request, #11054:
URL: https://github.com/apache/iotdb/pull/11054
## Description
https://github.com/apache/iotdb/pull/11046
When FastCompaction deserializes a overlapped Chunk into the Page queue, the ByteBuffer.get() method is called from the Chunk's Buffer to copy the data of each Page. After copy, the Page is wrapped into a PageElement and put into the pageQueue, but the timeChunk and valueChunks are passed into a new instance of AlignedChunkReader, which causes the clearChunks method to be called at the end of the method is not effective. The reference of each Chunk is still held by AlignedChunkReader and cannot be released. At this time, there is 2 times the chunk size of data in the memory.
## Fix
Release chunk data buffer after copy page data from it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To rel/1.1] Release chunk data buffer after copy page data from it in aligned series FastCompaction [iotdb]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou closed pull request #11054: [To rel/1.1] Release chunk data buffer after copy page data from it in aligned series FastCompaction
URL: https://github.com/apache/iotdb/pull/11054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org